Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MI-2711]: Create Countdown component #61

Merged
merged 30 commits into from
Apr 7, 2023
Merged

[MI-2711]: Create Countdown component #61

merged 30 commits into from
Apr 7, 2023

Conversation

SaurabhSharma-884
Copy link
Collaborator

Ticket ID:

https://brightscout.atlassian.net/browse/MI-2711

Description:

  • Add countdown component

Screenshots:

Default

Screenshot from 2023-02-06 15-23-26

Custom

Screenshot from 2023-02-06 15-23-36

@SaurabhSharma-884 SaurabhSharma-884 self-assigned this Feb 6, 2023
atisheyJain03

This comment was marked as outdated.

Sign in to view

atisheyJain03

This comment was marked as outdated.

Sign in to view

@atisheyJain03
Copy link

atisheyJain03 commented Feb 10, 2023 •
edited
Loading

@SaurabhSharma-884 do changes as discussed. If we hide day it must convert day time to hours.

@SaurabhSharma-884
Merge pull request #75 from Brightscout/MI-2931
528b290 
[MI-2931]: Fix option list on open and update version
@avas27JTG avas27JTG requested review from sooraj-shukla and removed request for atisheyJain03 April 3, 2023 06:58
sooraj-shukla
sooraj-shukla suggested changes Apr 3, 2023
View reviewed changes
src/components/Input/Input.component.tsx Outdated Show resolved Hide resolved
src/components/Countdown/index.ts Outdated Show resolved Hide resolved
src/components/Countdown/Countdown.styles.ts Outdated Show resolved Hide resolved
src/components/Input/Input.component.tsx Outdated Show resolved Hide resolved
src/components/Input/Input.component.tsx Outdated Show resolved Hide resolved
src/components/MMSearch/MMSearch.stories.tsx Outdated Show resolved Hide resolved
src/components/MultiProgress/MultiProgress.d.ts Outdated Show resolved Hide resolved
src/components/MMSearch/MMSearch.component.tsx Outdated Show resolved Hide resolved
src/components/MMSearch/MMSearch.d.ts Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
sooraj-shukla
sooraj-shukla suggested changes Apr 7, 2023
View reviewed changes
src/components/MMSearch/MMSearch.component.tsx Outdated Show resolved Hide resolved
src/components/MMSearch/MMSearch.component.tsx Outdated Show resolved Hide resolved
src/components/MMSearch/MMSearch.component.tsx Outdated Show resolved Hide resolved
src/components/MMSearch/MMSearch.component.tsx Outdated Show resolved Hide resolved
src/components/MMSearch/MMSearch.component.tsx Outdated Show resolved Hide resolved
@SaurabhSharma-884 SaurabhSharma-884 merged commit d6c2aa3 into mm_v6 Apr 7, 2023
@SaurabhSharma-884 SaurabhSharma-884 deleted the MI-2711 branch April 7, 2023 11:46
@SaurabhSharma-884 SaurabhSharma-884 mentioned this pull request Apr 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atisheyJain03 atisheyJain03 atisheyJain03 left review comments

@avas27JTG avas27JTG avas27JTG approved these changes

@sooraj-shukla sooraj-shukla sooraj-shukla approved these changes

Assignees

@SaurabhSharma-884 SaurabhSharma-884

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SaurabhSharma-884 @atisheyJain03 @avas27JTG @sooraj-shukla