Added [Constant] attribute. #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimothyJCowen
requested review from
j3parker,
mthjones and
omsmith
as code owners
omsmith
reviewed
Jan 4, 2021
omsmith
reviewed
Jan 4, 2021
omsmith
reviewed
Jan 4, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Also dunno if @j3parker still has reservations of this approach vs just doing it specifically for logging? Only know what was in that initial slack thread before the break. |
j3parker
reviewed
Jan 11, 2021
j3parker
reviewed
Jan 11, 2021
j3parker
reviewed
Jan 11, 2021
j3parker
reviewed
Jan 11, 2021
j3parker
reviewed
Jan 11, 2021
j3parker
previously approved these changes
Jan 11, 2021
Can be used to fix #518 - Added D2L.CodeStyle.Annotations.Contract.ConstantAttribute.cs - Added D2L.CodeStyle.Analyzers.Helpers.ConstantAnalyzer.cs - Added D2L.CodeStyle.Analyzers.Tests.Specs.ConstantAnalyzer.cs - Moved common method from Analyzers.ApiUsage.NotNullAnalyzer.cs to Analyzers.ExtensionMethods.cs - Changed to extension method on ISymbol
Added tests to check specific logging cases.
TimothyJCowen
force-pushed
the
TJ-LogConstants
branch
from
8d6cb08
to
df5c4bc
Compare
omsmith
reviewed
Jan 28, 2021
omsmith
reviewed
Jan 28, 2021
omsmith
reviewed
Jan 28, 2021
omsmith
reviewed
Jan 28, 2021
omsmith
reviewed
Jan 28, 2021
omsmith
reviewed
Jan 28, 2021
…ctly. Added more explanatory comments. Changed HasAttribute() to compare symbols instead of strings. Closes #697
omsmith
reviewed
Jan 28, 2021
src/D2L.CodeStyle.Analyzers/Extensions/Microsoft.CodeAnalysis.cs
Outdated
Show resolved
Hide resolved
omsmith
reviewed
Jan 28, 2021
omsmith
reviewed
Jan 28, 2021
omsmith
reviewed
Jan 28, 2021
Cleaned up comments and whitespace.
omsmith
reviewed
Feb 1, 2021
omsmith
reviewed
Feb 1, 2021
omsmith
reviewed
Feb 1, 2021
omsmith
reviewed
Feb 1, 2021
omsmith
reviewed
Feb 1, 2021
omsmith
reviewed
Feb 1, 2021
omsmith
previously approved these changes
Feb 1, 2021
j3parker
reviewed
Feb 1, 2021
Co-authored-by: Jacob Parker <jacob@solidangle.ca>
j3parker
approved these changes
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can be used to fix #518