Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update superagent to 3.4 #2

Merged
merged 1 commit into from
Feb 8, 2017
Merged

Update superagent to 3.4 #2

merged 1 commit into from
Feb 8, 2017

Conversation

ktonon
Copy link
Contributor

@ktonon ktonon commented Feb 8, 2017

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling c4d5050 on ktonon:master into 7e3d080 on Brightspace:master.

@ktonon
Copy link
Contributor Author

ktonon commented Feb 8, 2017

@omsmith does this look good? I have to wait for this to get published so I can submit PRs to the other repos which depend on it

@omsmith
Copy link
Contributor

omsmith commented Feb 8, 2017

Was waiting for a PR for frau-jwt still, https://github.com/Brightspace/frau-jwt/blob/master/package.json#L47

@ktonon
Copy link
Contributor Author

ktonon commented Feb 8, 2017

Sorry, I need some clarification. This is the dependency graph right?
deps

I figured since this repo (frau-xsrf-token) does not depend on the others, I should update this one first.

In order to update frau-superagent-xsrf-token, I need to have a published npm package for frau-xsrf-token (I assume version 2.0.0)

@omsmith
Copy link
Contributor

omsmith commented Feb 8, 2017

Ah quite, wasn't thinking of the version bumps between packages. Sorry!

@omsmith omsmith merged commit 3dd67b7 into Brightspace:master Feb 8, 2017
@ktonon
Copy link
Contributor Author

ktonon commented Feb 8, 2017

awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants