Change umdAppConfigBuilder to not append "app.js" #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,7 +1,7 @@ | |||
| var builder = require('../src/umdAppConfigBuilder'); | |||
|
|
|||
| var TARGET = 'example.com'; | |||
| var TARGET_WITH_TRAILING_SLASH = 'example.com/path/'; | |||
| var TARGET_WITH_TRAILING_SLASH = 'example.com/path/app.js'; | |||
There was a problem hiding this comment.
Is this still being used anywhere? I don't see any references. It can probably be deleted.
This is never how it should have behaved in the first place. It should be up to the caller to decide and specify the file name.
|
Other than what I suspect to be a declared variable that isn't reference, this looks good. |
cpacey
added a commit
that referenced
this pull request
Dec 18, 2014
Change umdAppConfigBuilder to not append "app.js"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is never how it should have behaved in the first place. It should be
up to the caller to decide and specify the file name.