(perf) manually decode the DER representation #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before: After: |
|
Would need additional tests for edge cases, such as the bad length ifs and whatnot |
omsmith
force-pushed
the
manual-decode
branch
from
d83e007
to
8dcc2c1
Compare
once again, given the limited domain of the problem, we're able to be very specific this way, we do one new buffer allocation, and ~1 copy
omsmith
force-pushed
the
manual-decode
branch
from
8dcc2c1
to
2b6278f
Compare
omsmith
added a commit
that referenced
this pull request
Nov 6, 2015
(perf) manually decode the DER representation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
once again, given the limited domain of the problem, we're able to be very specific
this way, we do one new buffer allocation, and ~1 copy