-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md to reflect move to Polymer 3 #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RageCage64
commented
Sep 19, 2019
- Removed all references to Bower
- Replaced bower install instructions with npm install instructions
- Changed filenames from .html to .js to reflect file names for the components in newest version
- Changed polymer documentation links to reference Polymer 3 pages
dlockhart
reviewed
Sep 19, 2019
dlockhart
reviewed
Sep 19, 2019
…ged to ES6 imports
dlockhart
reviewed
Sep 19, 2019
README.md
Outdated
@@ -30,7 +28,7 @@ Then import the components below that you want to use. | |||
### Alert | |||
```html | |||
<head> | |||
<link rel="import" href="../d2l-alert/d2l-alert.html"> | |||
import 'd2l-aler/d2l-alert.js'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These need to be wrapped in <script type="module">
tags.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also missing a t
dlockhart
approved these changes
Sep 20, 2019
svanherk
approved these changes
Oct 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.