Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logSnippet: false prevents the UI access URL from being displayed #1094

Closed
9 of 10 tasks
glen-84 opened this issue May 11, 2016 · 3 comments
Closed
9 of 10 tasks

logSnippet: false prevents the UI access URL from being displayed #1094

glen-84 opened this issue May 11, 2016 · 3 comments
Labels

Comments

@glen-84
Copy link
Contributor

glen-84 commented May 11, 2016

Issue details

I just want to hide the snippet of code, not the access URL(s).

Steps to reproduce/test case

Set logSnippet to false.

Please specify which version of Browsersync, node and npm you're running

  • Browsersync [ 2.12.5 ]
  • Node [ 5.11.0 ]
  • Npm [ 3.8.6 ]

Affected platforms

  • linux
  • windows
  • OS X
  • freebsd
  • solaris
  • other (please specify which)

Browsersync use-case

  • API
  • Gulp
  • Grunt
  • CLI

If CLI, please paste the entire command below

n/a

for all other use-cases, (gulp, grunt etc), please show us exactly how you're using Browsersync

n/a

@shakyShane shakyShane added the bug label May 12, 2016
@shakyShane
Copy link
Contributor

good catch! this is a bug that will be fixed asap :)

@shakyShane
Copy link
Contributor

Maybe you could send a PR @glen-84 ?

here's the offending code, it would be good to have you on board as a contributor :)

browser-sync/lib/logger.js

Lines 136 to 150 in ce6a293

if (type === "snippet" && bs.options.get("logSnippet")) {
logger.info(
"{bold:Copy the following snippet into your website, " +
"just before the closing {cyan:</body>} tag"
);
logger.unprefixed("info",
messages.scriptTags(bs.options)
);
logUrls(bs.options.get("urls").filter(function (value, key) {
return key.slice(0, 2) === "ui";
}).toJS());
}

@glen-84
Copy link
Contributor Author

glen-84 commented May 12, 2016

#1095

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants