Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1094 #1095

Merged
merged 2 commits into from
May 12, 2016
Merged

Fix #1094 #1095

merged 2 commits into from
May 12, 2016

Conversation

glen-84
Copy link
Contributor

@glen-84 glen-84 commented May 12, 2016

No description provided.

@glen-84
Copy link
Contributor Author

glen-84 commented May 12, 2016

Actually this can probably be optimized ... give me a min.

@glen-84
Copy link
Contributor Author

glen-84 commented May 12, 2016

Looks like I may have broken an e2e test. :(

@glen-84
Copy link
Contributor Author

glen-84 commented May 12, 2016

@shakyShane Looks like the test just fails because console.log is now called. Not sure how you want to deal with this.

@glen-84 glen-84 mentioned this pull request May 12, 2016
Closed
10 tasks
@shakyShane
Copy link
Contributor

Don't worry I will fix the tests :)

@shakyShane shakyShane merged commit 7795031 into BrowserSync:master May 12, 2016
@shakyShane
Copy link
Contributor

published on npm at browser-sync@2.12.8

Thanks for contributing, I hope I made it a painless process for you :)

@glen-84 glen-84 deleted the patch-1 branch May 12, 2016 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glen-84 @shakyShane