Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply JSCS and JSHint to the protractor test files / Update deps #339

Merged
merged 5 commits into from
Nov 25, 2014
Merged

Conversation

shinnn
Copy link
Contributor

@shinnn shinnn commented Nov 25, 2014

  • I updated the settings of the lint task and .jshintrc to apply JSCS and JSHint to the protoractor test files.
  • I fixed coding styles according to the report of JSCS and JSHint.
  • I replaced async with async-each-series.
    • This project doesn't use the gadzillion methods in async.
  • I updated dependencies and devDependencies.
  • I updated bin field of package.json.
    • According to the documentation of package.json:

      If you have a single executable, and its name should be the name of the package, then you can just supply it as a string.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling c9414a7 on shinnn:patch into dfaa877 on shakyShane:master.

shakyShane added a commit that referenced this pull request Nov 25, 2014
Apply JSCS and JSHint to the protractor test files / Update deps
@shakyShane shakyShane merged commit e423ca3 into BrowserSync:master Nov 25, 2014
@shakyShane
Copy link
Contributor

@shinnn shinnn deleted the patch branch November 26, 2014 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants