bugfix(core): Allow circular structures for dynamic module nestjs#678

BrunnerLivio · Oct 2, 2018 · 3dd8b03 · 3dd8b03
1 parent 65bb7e7
commit 3dd8b03
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/packages/core/injector/module-token-factory.ts b/packages/core/injector/module-token-factory.ts
@@ -2,6 +2,7 @@ import { DynamicModule } from '@nestjs/common';
 import { SHARED_MODULE_METADATA } from '@nestjs/common/constants';
 import { Type } from '@nestjs/common/interfaces/type.interface';
 import * as hash from 'object-hash';
+import safeStringify from 'fast-safe-stringify';
 
 export class ModuleTokenFactory {
   public create(
@@ -22,7 +23,9 @@ export class ModuleTokenFactory {
   public getDynamicMetadataToken(
     dynamicModuleMetadata: Partial<DynamicModule> | undefined,
   ): string {
-    return dynamicModuleMetadata ? JSON.stringify(dynamicModuleMetadata) : '';
+    // Uses safeStringify instead of JSON.stringify
+    // to support circular dynamic modules
+    return dynamicModuleMetadata ? safeStringify(dynamicModuleMetadata) : '';
   }
 
   public getModuleName(metatype: Type<any>): string {

diff --git a/packages/core/test/injector/module-token-factory.spec.ts b/packages/core/test/injector/module-token-factory.spec.ts
@@ -2,6 +2,7 @@ import { expect } from 'chai';
 import * as hash from 'object-hash';
 import { SingleScope } from '../../../common';
 import { ModuleTokenFactory } from '../../injector/module-token-factory';
+import safeStringify from 'fast-safe-stringify';
 
 describe('ModuleTokenFactory', () => {
   let factory: ModuleTokenFactory;
@@ -46,7 +47,7 @@ describe('ModuleTokenFactory', () => {
       expect(token).to.be.deep.eq(
         hash({
           module: Module.name,
-          dynamic: JSON.stringify({
+          dynamic: safeStringify({
             components: [{}],
           }),
           scope: [Module.name],