-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSON output writer #28
Conversation
1 similar comment
25372c2
to
af93564
Compare
@Brunty this PR is now ready for review. It currently outputs a line of JSON per result/error/stats. Changing it to do it in one big JSON object would have meant a bigger change. Up to you if you prefer it per line or one big JSON object. Example output: |
Hmm, I'll give it some thought, will look at the pros / cons of each - depends on use case, one big object would make it easier to parse / use in another tool for working with the output. Also wondering about the possibility of a pretty print flag too, not useful for machines, but useful for people perhaps? Using |
Hmmm the |
@WyriHaximus - cool, if there's anything I can help with let me know. I've got some downtime today so I'm going to take a look at this PR. Thanks for the work once again <3 |
…t instead of multiple
* Extract echoing output into an EchoWriter * The passed argument on WriterInterface::writeStats must be a bool not a float * EchoWriter must implement WriterInterface * JsonWriter * Added -j/--json option to the cigar bin script * Taken #28 and refactored it into outputting a single JSON object instead of multiple
Implements / Closes #24
Closes #29
TODO: