Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PSP61 #112

Merged
merged 17 commits into from
Aug 30, 2023
Merged

PSP61 #112

merged 17 commits into from
Aug 30, 2023

Conversation

varex83
Copy link
Contributor

@varex83 varex83 commented Jul 18, 2023 •
edited
Loading

PSP61

  • Logic
  • Implementation macro
  • PSP Draft
  • Tests
  • Manual tests

@github-actions
Copy link

github-actions bot commented Jul 18, 2023 •
edited
Loading

Contract Name main feature/erc165 Difference
contract_v1 10813 10773 -40
contract_v2 12439 12425 -14
diamond_caller 5534 5534 0
lending_contract 41551 41654 103
loan_contract 19803 19807 4
my_diamond 12483 12481 -2
my_proxy 4234 4234 0
my_psp22_facet_v1 9455 9451 -4
my_psp22_facet_v2 9141 9139 -2
my_psp22_metadata_facet 5039 5162 123
my_psp22_metadata_upgradeable 13490 13491 1
my_psp22_upgradeable 10423 10414 -9
shares_contract 13531 13568 37
stable_coin_contract 11354 11344 -10

@varex83 varex83 changed the title [WIP] ERC165 [WIP] PSP61 Jul 18, 2023
Artemka374
Artemka374 suggested changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@Artemka374 Artemka374 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm overall, just add a failing test

examples/psp61/lib.rs Show resolved Hide resolved
@Artemka374 Artemka374 marked this pull request as ready for review August 29, 2023 13:15
@Artemka374 Artemka374 changed the title [WIP] PSP61 PSP61 Aug 29, 2023
@Artemka374 Artemka374 merged commit 1371707 into develop Aug 30, 2023
6 of 7 checks passed
@Artemka374 Artemka374 deleted the feature/erc165 branch August 30, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Artemka374 Artemka374 Artemka374 requested changes

@coreggon11 coreggon11 Awaiting requested review from coreggon11

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@varex83 @Artemka374