Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-59764 #96

Closed
wants to merge 191 commits into from
Closed

LPS-59764 #96

wants to merge 191 commits into from

Conversation

ssmith353
Copy link

Just adding a portal property so that on the Remote Live site, the "Configuration" and the "Look and Feel" menu options don't show up. At this point, on the live site, they are configurable, despite the fact that a subsequent publish will overwrite the changes.

Some users may want the original functionality, so I've left it in place, and added a property to change it to fit the use case noted on LPS-59764.

juliocamarero and others added 30 commits October 22, 2015 13:29
… "com.liferay.portal.kernel.cache" to "com.liferay.portal.kernel.cache.thread.local"
…al.cache" to "com.liferay.portal.cache.thread.local"
@liferay-continuous-integration
Copy link
Collaborator

Some tests FAILED!

Build Time: 28 minutes 32 seconds

Base Branch:

Branch Name: master
Branch GIT ID: 7091a98e4c20d45003a346a8d5a3ce68db8be91c

Job Summary:

For more details click here.

Failed Jobs:

  1. test-portal-acceptance-pullrequest(master)
    Job Results:

    21 Jobs Passed.
    2 Jobs Failed.

    Completed with the status of FAILURE.
  2. test-portal-acceptance-pullrequest-batch(master)/modules-integration-oracle
    Job Results:

    15 Tests Passed.
    1 Test Failed.

    1. test-portal-acceptance-pullrequest-batch(master) ?? 3,!master #4950

      root 19599 0.0 0.0 4076 536 ? S 15:04 0:00 sleep 60
      root 19661 0.0 0.0 9208 1232 pts/0 S+ 15:04 0:00 /bin/bash -e -x /tmp/hudson302814324320317122.sh
      root 19663 0.0 0.0 9208 1312 pts/0 S+ 15:04 0:00 /bin/bash commands/build-test-portal-acceptance-pullrequest-batch.sh
      root 19667 8.3 1.5 2842060 132548 pts/0 Sl+ 15:04 0:02 /opt/java/jdk/jre/bin/java -Dhttp.nonProxyHosts=localhost|test\* -Dhttp.proxyHost=squid.lax.liferay.com -Dhttp.proxyPort=3128 -server -verbose:gc -Xloggc:/tmp/ant-gc.log -Xms1024m -Xmx2048m -Xss2m -Xverify:none -XX:+DisableExplicitGC -XX:+HeapDumpOnOutOfMemoryError -XX:+PrintGCCause -XX:+PrintGCDetails -XX:+UseParallelOldGC -XX:HeapDumpPath=/tmp/ant-oom-heap-dump.bin -XX:MaxNewSize=512m -XX:MaxPermSize=512m -XX:MaxTenuringThreshold=0 -XX:NewSize=256m -XX:PermSize=100m -XX:SurvivorRatio=65536 -XX:TargetSurvivorRatio=0 -classpath /opt/java/ant/lib/ant-launcher.jar -Dant.home=/opt/java/ant -Dant.library.dir=/opt/java/ant/lib org.apache.tools.ant.launch.Launcher -cp -f commands/build-test-portal-acceptance-pullrequest-batch.xml
      root 19754 0.0 0.0 13376 1056 pts/0 R+ 15:05 0:00 ps a u x
      zabbix 24181 0.0 0.0 76880 472 ? S Oct21 0:00 zabbix_agentd -c /etc/zabbix/zabbix_agentd.conf
      zabbix 24183 0.0 0.0 76880 948 ? S Oct21 0:08 zabbix_agentd: collector [idle 1 sec]
      zabbix 24184 0.0 0.0 78952 840 ? S Oct21 0:00 zabbix_agentd: listener #1 [waiting for connection]
      zabbix 24185 0.0 0.0 78952 840 ? S Oct21 0:00 zabbix_agentd: listener #2 [waiting for connection]
      zabbix 24186 0.0 0.0 78952 840 ? S Oct21 0:00 zabbix_agentd: listener #3 [waiting for connection]
      zabbix 24187 0.0 0.0 78960 928 ? S Oct21 0:02 zabbix_agentd: active checks #1 [idle 1 sec]
      dasusr1 28550 0.0 0.0 540972 2248 ? Sl Aug20 0:23 /home/dasusr1/das/adm/db2dasrrm

@ssmith353
Copy link
Author

ci:retest

@liferay-continuous-integration
Copy link
Collaborator

Some tests FAILED!

Build Time: 32 minutes 16 seconds

Base Branch:

Branch Name: master
Branch GIT ID: ef6fc9d7afb9b8a5301e509ba3c67866485a5f00

Job Summary:

For more details click here.

Failed Jobs:

  1. test-portal-acceptance-pullrequest(master)
    Job Results:

    21 Jobs Passed.
    2 Jobs Failed.

    Completed with the status of FAILURE.
  2. test-portal-acceptance-pullrequest-batch(master)/integration-db2
    Job Results:

    5 Tests Passed.
    1 Test Failed.

    1. test-portal-acceptance-pullrequest-batch(master) ?? 3,!master #3240

      dasusr1 27944 0.0 0.0 551212 2168 ? Sl Sep15 0:17 /home/dasusr1/das/adm/db2dasrrm
      root 28176 0.0 0.0 4076 536 ? S 15:43 0:00 sleep 60
      root 28237 0.0 0.0 9208 1232 pts/0 S+ 15:43 0:00 /bin/bash -e -x /tmp/hudson256558160131488833.sh
      root 28239 0.0 0.0 9208 1304 pts/0 S+ 15:43 0:00 /bin/bash commands/build-test-portal-acceptance-pullrequest-batch.sh
      root 28243 7.1 1.5 2842188 133600 pts/0 Sl+ 15:43 0:02 /opt/java/jdk/jre/bin/java -Dhttp.nonProxyHosts=localhost|test\* -Dhttp.proxyHost=squid.lax.liferay.com -Dhttp.proxyPort=3128 -server -verbose:gc -Xloggc:/tmp/ant-gc.log -Xms1024m -Xmx2048m -Xss2m -Xverify:none -XX:+DisableExplicitGC -XX:+HeapDumpOnOutOfMemoryError -XX:+PrintGCCause -XX:+PrintGCDetails -XX:+UseParallelOldGC -XX:HeapDumpPath=/tmp/ant-oom-heap-dump.bin -XX:MaxNewSize=512m -XX:MaxPermSize=512m -XX:MaxTenuringThreshold=0 -XX:NewSize=256m -XX:PermSize=100m -XX:SurvivorRatio=65536 -XX:TargetSurvivorRatio=0 -classpath /opt/java/ant/lib/ant-launcher.jar -Dant.home=/opt/java/ant -Dant.library.dir=/opt/java/ant/lib org.apache.tools.ant.launch.Launcher -cp -f commands/build-test-portal-acceptance-pullrequest-batch.xml
      root 28324 0.0 0.0 13376 1056 pts/0 R+ 15:44 0:00 ps a u x

@BryanEngler
Copy link
Owner

so without actually looking at the fix too much, the comments on the lpp make this look like its just a pr to get approved for an sdh?

the problem with that is, if this actually isnt a bug, we shouldnt sdh it, and if they want they can just make a customization like you mentioned on the lpp.

if youre not sure if its a bug or not you can ask on the forums. also, i tested it real quick on base 6210 and it looks like the configs werent available. so you can maybe find an LPS where we intentionally added the configs and give the customer those reasons, or maybe you can find an LPS that caused this possible regression and see what caused it and if that can give you some hints as to what the fix should be since you didnt seem to confident in this fix...

im gonna close this but if you can confirm that it is a bug, either resend this or make a new fix that you have more confidence with if you can find out what caused the regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet