New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LPS-59764 #96
LPS-59764 #96
Conversation
…not only the attribute in the request
…tener, prepare for moving out
…e package"com.liferay.portal.cache"
… "com.liferay.portal.kernel.cache" to "com.liferay.portal.kernel.cache.thread.local"
…al.cache" to "com.liferay.portal.cache.thread.local"
…putation is accurate
Some tests FAILED!Build Time: 28 minutes 32 seconds Base Branch:Branch Name: master Job Summary:
For more details click here.Failed Jobs:
|
ci:retest |
so without actually looking at the fix too much, the comments on the lpp make this look like its just a pr to get approved for an sdh? the problem with that is, if this actually isnt a bug, we shouldnt sdh it, and if they want they can just make a customization like you mentioned on the lpp. if youre not sure if its a bug or not you can ask on the forums. also, i tested it real quick on base 6210 and it looks like the configs werent available. so you can maybe find an LPS where we intentionally added the configs and give the customer those reasons, or maybe you can find an LPS that caused this possible regression and see what caused it and if that can give you some hints as to what the fix should be since you didnt seem to confident in this fix... im gonna close this but if you can confirm that it is a bug, either resend this or make a new fix that you have more confidence with if you can find out what caused the regression |
Just adding a portal property so that on the Remote Live site, the "Configuration" and the "Look and Feel" menu options don't show up. At this point, on the live site, they are configurable, despite the fact that a subsequent publish will overwrite the changes.
Some users may want the original functionality, so I've left it in place, and added a property to change it to fit the use case noted on LPS-59764.