Avoid converting from IEnumerable to IList

Casting is wrong and can throw exception. mono/mono#14729
BrzVlad · Jun 6, 2019 · 992c539 · 992c539
1 parent 55c4073
commit 992c539
Show file tree

Hide file tree

Showing 8 changed files with 9 additions and 9 deletions.
diff --git a/tests/bcl-test/templates/common/TestRunner.Core/TestRunner.cs b/tests/bcl-test/templates/common/TestRunner.Core/TestRunner.cs
@@ -30,7 +30,7 @@ protected TestRunner (LogWriter logger)
 			Logger = logger ?? throw new ArgumentNullException (nameof (logger));
 		}
 
-		public abstract void Run (IList <TestAssemblyInfo> testAssemblies);
+		public abstract void Run (IEnumerable<TestAssemblyInfo> testAssemblies);
 		public abstract string WriteResultsToFile ();
 		public abstract void WriteResultsToFile (TextWriter writer);
 		public abstract void SkipTests (IEnumerable<string> tests);
@@ -102,4 +102,4 @@ protected virtual string GetResultsFilePath ()
 			return Path.Combine (resultsPath, ResultsFileName);
 		}
 	}
-}
+}
diff --git a/tests/bcl-test/templates/common/TestRunner.NUnit/NUnitTestRunner.cs b/tests/bcl-test/templates/common/TestRunner.NUnit/NUnitTestRunner.cs
@@ -35,7 +35,7 @@ public NUnitTestRunner (LogWriter logger) : base (logger)
 			builderSettings = new Dictionary<string, object> (StringComparer.OrdinalIgnoreCase);
 		}
 
-		public override void Run (IList<TestAssemblyInfo> testAssemblies)
+		public override void Run (IEnumerable<TestAssemblyInfo> testAssemblies)
 		{
 			if (testAssemblies == null)
 				throw new ArgumentNullException (nameof (testAssemblies));

diff --git a/tests/bcl-test/templates/common/TestRunner.xUnit/XUnitTestRunner.cs b/tests/bcl-test/templates/common/TestRunner.xUnit/XUnitTestRunner.cs
@@ -679,7 +679,7 @@ void do_log (string message, Action<string> log = null, StringBuilder sb = null)
 			log (message);
 		}
 
-		public override void Run (IList <TestAssemblyInfo> testAssemblies)
+		public override void Run (IEnumerable<TestAssemblyInfo> testAssemblies)
 		{
 			if (testAssemblies == null)
 				throw new ArgumentNullException (nameof (testAssemblies));

diff --git a/tests/bcl-test/templates/iOSApp/ViewController.cs b/tests/bcl-test/templates/iOSApp/ViewController.cs
@@ -111,7 +111,7 @@ public async override void ViewDidLoad ()
 				runner.SkipTests (skippedTests);
 			}
 
-			runner.Run ((IList<TestAssemblyInfo>)testAssemblies);
+			runner.Run (testAssemblies);
 			if (options.EnableXml) {
 				runner.WriteResultsToFile (writer);
 				logger.Info ("Xml file was written to the tcp listener.");

diff --git a/tests/bcl-test/templates/macOS/MacTestMain.cs b/tests/bcl-test/templates/macOS/MacTestMain.cs
@@ -82,7 +82,7 @@ static int RunTests (string [] original_args)
 				// ensure that we skip those tests that have been passed via the ignore files
 				runner.SkipTests (skippedTests);
 			}
-			runner.Run (testAssemblies.ToList ());
+			runner.Run (testAssemblies);
 
 			if (options.ResultFile != null) {
 				using (var writer = new StreamWriter (options.ResultFile)) {

diff --git a/tests/bcl-test/templates/today/TodayExtensionMain.cs b/tests/bcl-test/templates/today/TodayExtensionMain.cs
@@ -87,7 +87,7 @@ public void WidgetPerformUpdate (Action<NCUpdateResult> completionHandler)
 		{
 			BeginInvokeOnMainThread (() =>
 			{
-				runner.Run ((IList<TestAssemblyInfo>)testAssemblies);
+				runner.Run (testAssemblies);
 			});
 		});
 

diff --git a/tests/bcl-test/templates/tvOSApp/ViewController.cs b/tests/bcl-test/templates/tvOSApp/ViewController.cs
@@ -109,7 +109,7 @@ public async override void ViewDidLoad ()
 				runner.SkipTests (skippedTests);
 			}
 
-			runner.Run ((IList<TestAssemblyInfo>)testAssemblies);
+			runner.Run (testAssemblies);
 			if (options.EnableXml) {
 				runner.WriteResultsToFile (writer);
 				logger.Info ("Xml file was written to the tcp listener.");

diff --git a/tests/bcl-test/templates/watchOS/Extension/InterfaceController.cs b/tests/bcl-test/templates/watchOS/Extension/InterfaceController.cs
@@ -150,7 +150,7 @@ void RunTests ()
 				BeginInvokeOnMainThread (() =>
 				{
 					lblStatus.SetText (string.Format ("{0} tests", runner.TotalTests));
-					runner.Run ((IList<TestAssemblyInfo>)testAssemblies);
+					runner.Run (testAssemblies);
 					RenderResults ();
 					cmdRun.SetEnabled (true);
 					cmdRun.SetHidden (false);