Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the mod to 1.19.4 #46

Closed
wants to merge 7 commits into from
Closed

Conversation

TechPro424
Copy link
Contributor

This PR updates the mod to 1.19.4

I was approached by a user on Discord named dreamcatcher#8788 to update the mod to 1.19.4, which I did
There aren't many changes, just migrated the mappings and updated the dependencies
It worked fine on my end, and I gave a build to dreamcatcher to test, they got back to me saying that everything worked fine.

I also specifically asked them to test if the issue mentioned by @Bstn1802 in #38 occurs, and they told me that it does not, so the mod can probably be released to CurseForge without any changes.

I also updated the license in the fabric.mod.json to GPL-3.0, to match the license on the GH repo
On that note, you should probably take a look at #42, as the GPL license is not advisable for Minecraft mods.

The only change that you might want to revert is c389e62, which I made because, for some reason, the variables were not resolving when I launched the game, and I got an error saying that the variables were invalid.

@cunhar
Copy link

cunhar commented Apr 10, 2023

@TechPro424 could i get a build of this latest working version to help test as well.

@TechPro424
Copy link
Contributor Author

@TechPro424 could i get a build of this latest working version to help test as well.

The mod jar is in the zip file
autoreconnect-3.0.0-beta.zip

@TechPro424
Copy link
Contributor Author

@cunhar have you tested the mod?
And if yes, did you experience any issues?

@cunhar
Copy link

cunhar commented May 10, 2023

@TechPro424 it works great. ive been using it on my server stream for over a month at this point and we've stayed connected the whole time.

@TechPro424 TechPro424 mentioned this pull request May 26, 2023
@TechPro424
Copy link
Contributor Author

This PR fixes #48

@xanulus
Copy link

xanulus commented Jun 19, 2023

Hey, very interested in getting this to work for 1.20 or 1.20.1. If there are any plans to update to the newer version it would be very much appreciated!

@TechPro424
Copy link
Contributor Author

I'll work on updating this PR to 1.20

@cunhar
Copy link

cunhar commented Jun 19, 2023

thank you @TechPro424

@TechPro424
Copy link
Contributor Author

TechPro424 commented Jun 19, 2023

1.20 build: autoreconnect-3.0.0-beta.zip
Please test on both 1.20 and 1.20.1
the mod jar is inside the zip file

Let me know if there are any issues!
(Also, please test specifically if the issue mentioned by @Bstn1802 in #38 occurs)

edit: it seems there's already a PR for 1.20: #49
I'll close this one

@TechPro424 TechPro424 closed this Jun 19, 2023
@EnderKill98 EnderKill98 mentioned this pull request Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants