Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] New IconTasklist favorite icon not themable #562

Closed
JoshStrobl opened this issue Apr 16, 2024 · 0 comments · Fixed by #563
Closed

[Bug] New IconTasklist favorite icon not themable #562

JoshStrobl opened this issue Apr 16, 2024 · 0 comments · Fixed by #563
Assignees
Labels
bug Something isn't working
Milestone

Comments

@JoshStrobl
Copy link
Member

Description

With the inclusion of the rewritten IconTasklist in #553, the favorite icon was changed to a new heart (budgie-app-favorited / budgie-app-unfavorited). This icon has a fixed color (Budgie's green) rather than any primary color defined by the theme.

@EbonJaeger and I both independently investigated making this effectively a symbolic that would be themed using .alert class that our existing notification icon uses, however the theming does not apply correctly to the popover.

This should be investigated and resolved (either with a proper fix or a revert to old iconography) before our next release.

Budgie version

git-bf436dbf53963a18209b6c10bb738f56db899580

Operating System

Fedora 40

Steps to reproduce the issue

Right click on an IconButton, notice that the favorited icon (if the app is favorited) is a fixed green.

Actual result

Icon not themable.

Expected result

Icon is themable.

Additional information

No response

@JoshStrobl JoshStrobl added the bug Something isn't working label Apr 16, 2024
@JoshStrobl JoshStrobl added this to the 10.10 milestone Apr 16, 2024
@JoshStrobl JoshStrobl self-assigned this Apr 16, 2024
@JoshStrobl JoshStrobl linked a pull request Apr 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant