Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: inability for popover pin button to be themed #563

Merged
merged 2 commits into from Apr 18, 2024
Merged

fix: inability for popover pin button to be themed #563

merged 2 commits into from Apr 18, 2024

Conversation

JoshStrobl
Copy link
Member

Description

Fixes inability for popover pin button to be themed.

For reviewers: Only actual change in the SASS is the following code block. Rest I shall blame on format-on-save.

.icon-popover {
  .icon-popover-pin.alert {
    color: $alert_color;
  }
}

@JoshStrobl
fix: inability for popover pin button to be themed
8e59f67 
Theme developers should apply same .alert as done for notification icon
@JoshStrobl JoshStrobl added this to the 10.10 milestone Apr 16, 2024
@JoshStrobl JoshStrobl self-assigned this Apr 16, 2024
@JoshStrobl JoshStrobl linked an issue Apr 16, 2024 that may be closed by this pull request
[Bug] New IconTasklist favorite icon not themable #562
Closed
EbonJaeger
EbonJaeger approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@EbonJaeger EbonJaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from no newline at the end of meson.build, LGTM!

@JoshStrobl
Copy link
Member Author

Ah true, sec

@JoshStrobl
Copy link
Member Author

Fixed.

EbonJaeger
EbonJaeger approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@EbonJaeger EbonJaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, LGTM!

@serebit serebit added the bug Something isn't working label Apr 18, 2024
serebit
serebit approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@serebit serebit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@serebit serebit merged commit ee9807a into main Apr 18, 2024
1 check passed
@serebit serebit deleted the 562-bug-new-icontasklist-favorite-icon-not-themable branch April 18, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EbonJaeger EbonJaeger EbonJaeger approved these changes

@serebit serebit serebit approved these changes

Assignees

@JoshStrobl JoshStrobl

Labels
bug Something isn't working
Projects
Budgie 10
Status: Done
Milestone
10.10
Development

Successfully merging this pull request may close these issues.

[Bug] New IconTasklist favorite icon not themable
3 participants
@JoshStrobl @EbonJaeger @serebit