Let peas chew on v2.0 for python based plugins #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compiling with release + optimisation flags resulted in various memory corruption issues, noticably visible with python plugins but also the status indicator applet. These changes tidies up the derived type implementation along the guidelines given upstream.
EbonJaeger
requested changes
Jul 18, 2024
| @@ -16,16 +18,15 @@ | |||
|
|
|||
| G_BEGIN_DECLS | |||
|
|
|||
| G_DECLARE_DERIVABLE_TYPE(BudgiePopover, budgie_popover, BUDGIE, POPOVER, GtkPopover) | |||
| #define T_TYPE_BUDGIE_POPOVER (budgie_popover_get_type ()) | |||
There was a problem hiding this comment.
By modern conventions, the type should be BUDGIE_TYPE_POPOVER.
| } | ||
|
|
||
| static void budgie_popover_finalize (GObject* object) { | ||
| BudgiePopover *popover = budgie_popover_get_instance_private(T_BUDGIE_POPOVER (object)); |
| GtkStyleContext * style = gtk_widget_get_style_context(popover); | ||
| gtk_style_context_add_class(style, "budgie-popover"); | ||
| static void budgie_popover_class_init(BudgiePopoverClass* klass) { | ||
| GtkWidgetClass* widget_class = GTK_WIDGET_CLASS(klass); |
There was a problem hiding this comment.
This doesn't look like it's being used.
EbonJaeger
requested changes
Jul 18, 2024
Comment on lines
+15
to
+17
| typedef struct { | ||
| GtkPopover parent_instance; | ||
| } BudgiePopoverPrivate; |
There was a problem hiding this comment.
This also seems wrong. I would look at this class in the trash applet, which is also a derivable type with private data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For wayland we need to ensure python based plugins are v2.0
Submitter Checklist
git rebase -i(if needed)