Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add placeholder for Debian install instructions #20

Merged
merged 3 commits into from
Apr 2, 2023

Conversation

serebit
Copy link
Member

@serebit serebit commented Apr 2, 2023

Relates to #15.

@serebit serebit requested a review from JoshStrobl April 2, 2023 03:16
@@ -84,7 +84,9 @@ const SupportList = () => {
<OpenInNew />
</IconButton>
</Stack>
<info.installationInfo key={`InstallationInfo-${info.name}`} />
<Stack>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this being wrapped in a Stack?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's for compatibility with #19. Without a top-level Stack when there's only a single element in info.installationInfo, the margin on the last element is removed, which results in no visual padding on the bottom edge of the card. Now that #19 has been merged, you can see for yourself.

@serebit serebit requested a review from JoshStrobl April 2, 2023 15:21
…nctions.

Instead shift the stack into SupportList component.
@JoshStrobl JoshStrobl merged commit af04d08 into main Apr 2, 2023
@JoshStrobl JoshStrobl deleted the add-debian-placeholder branch April 2, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants