REST file handling and SMTP automation block attachments #13403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PClmnt
added
feature-branch
…rom-object-store When sending a file attachment in email fetch it directly from our object store
…d-rest-file-handling
adrinr
reviewed
Apr 22, 2024
packages/builder/src/components/automation/SetupPanel/AutomationBlockSetup.svelte
Show resolved
Hide resolved
| @@ -162,6 +164,42 @@ export async function sendEmail( | |||
| contents: opts?.contents, | |||
| }), | |||
| } | |||
| if (opts?.attachments) { | |||
| const attachments = await Promise.all( | |||
| opts.attachments?.map(async attachment => { | |||
There was a problem hiding this comment.
We don't need to worry for now, but this can cause some kind of DDoS if we don't limit the attachment length
adrinr
approved these changes
Apr 22, 2024
* Updating TTL handling in upload functions * describe ttl type * account for ttl creation in existing buckets and update types * fix tests
…d-rest-file-handling
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merging base feature branch of 2 PRs into master:
Feature branch env
Feature Branch Link
Launchcontrol