Fix relationships disappearing #13526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrinr
force-pushed
the
BUDI-8181/fix-relationships-disappearing
branch
from
5f9ec34
to
874c698
Compare
adrinr
requested review from
samwho,
mike12345567 and
a team
and removed request for
a team
adrinr
changed the title
mike12345567
approved these changes
Apr 19, 2024
mike12345567
approved these changes
Apr 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We recently introduced a change where we were persisting existing schema changes to avoid dropping column settings. This caused some issues with columns non-persisted externally when fetching schema from source, such as links or formulas.
This PR is fixing this issue, adding a test that will check that we are not dropping unexpected data when synching from schema
Addresses
Launchcontrol
Fixing some links and formulas dropping when re-fetching from schema