Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve oss pro via yarn resolutions #13559

Merged
merged 4 commits into from
Apr 25, 2024

Conversation

adrinr
Copy link
Collaborator

@adrinr adrinr commented Apr 25, 2024

Description

Currently we have a script that changes the pro package to use latest when the code is running without the submodules. This is often confusing and it makes solving OSS issues harder. We removed this logic using yarn resolutions instead. If the submodule exist, yarn will automatically pick the local one. Otherwise it will pull from the npm registry.

yarn why with the submodule loaded yarn why without the submodule
image image

OSS pipeline run:

Addresses

Copy link
Collaborator

@mike12345567 mike12345567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - this does seem to work - its an interesting behaviour! Nice to get rid of the scripts around this.

@adrinr adrinr merged commit 6166410 into master Apr 25, 2024
10 checks passed
@adrinr adrinr deleted the chore/resolve-oss-pro-via-yarn-resolutions branch April 25, 2024 11:00
@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants