Move more tests out of sql.spec.ts
#13740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrinr
reviewed
May 22, 2024
| @@ -73,7 +74,7 @@ describe.each([ | |||
| }) | |||
|
|
|||
| async function createTable(schema: TableSchema) { | |||
| table = await config.api.table.save( | |||
| return await config.api.table.save( | |||
| @@ -1506,4 +1540,52 @@ describe.each([ | |||
| expectQuery({ equal: { "1:1:name": "none" } }).toFindNothing()) | |||
| }) | |||
| }) | |||
|
|
|||
| // This will never work for Lucene. | |||
| // TODO(samwho): fix for SQS | |||
There was a problem hiding this comment.
Is this meant to be done before merging?
There was a problem hiding this comment.
Ah, @mike12345567 actually fixed this. Lemme "uncomment" the test. Good catch!
There was a problem hiding this comment.
Was just the comment that needed removing, the condition was already allowing the SQS test variant to run.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This continues the work of #13734 in moving more and more tests out of
sql.spec.tsand into various integration test files.