Fix failing test due testcontainer conflicts #14229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrinr
commented
Jul 24, 2024
| @@ -10,7 +10,18 @@ | |||
| }, | |||
| "targetDefaults": { | |||
| "build": { | |||
| "inputs": ["{workspaceRoot}/scripts/*", "{workspaceRoot}/lerna.json"] | |||
There was a problem hiding this comment.
This will enforce running build and test when the workflows are updated. Otherwise, something might be skipped if there are no changes on the actual packages
adrinr
requested review from
samwho and
mike12345567
and removed request for
a team
|
Related to microsoft/mssql-docker#892 |
mike12345567
approved these changes
Jul 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing mssql testcontainer wait strategy. The image has been updated and the script was broken, not allowing starting the containers properly. Changing the tag to not the latest fixes it temporarily.