Fix query binding drawer bindable options #4128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g sure correct ones are available.
|
Was just looking at this file - for some reason it has props for both |
aptkingston
reviewed
Jan 20, 2022
packages/builder/src/components/integration/QueryBindingBuilder.svelte
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #4128 +/- ##
=======================================
Coverage 68.92% 68.92%
=======================================
Files 139 139
Lines 4634 4634
Branches 685 685
=======================================
Hits 3194 3194
Misses 1018 1018
Partials 422 422 Continue to review full report at Codecov.
|
shogunpurple
approved these changes
Jan 20, 2022
… variable with queryBindings.
Rory-Powell
approved these changes
Jan 20, 2022
aptkingston
approved these changes
Jan 20, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for #4126 - wrong bindings were being passed to the drawer, making sure correct ones are available.