Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc MongoDB Connector Fixes #5877

Merged
merged 10 commits into from
May 16, 2022
Merged

Misc MongoDB Connector Fixes #5877

merged 10 commits into from
May 16, 2022

Conversation

mike12345567
Copy link
Collaborator

Description

Rebase of #5875 for @melohagan

Added support for ObjectIds. Made some fixes for the CRUD operations.

Addresses:

There's still a number of improvements to be done in the V2 connector, but this should help a bit in the meantime.

Screenshots

Insert
mongodb_insert

Update
mongodb_update

@codecov-commenter
Copy link

codecov-commenter commented May 13, 2022

Codecov Report

Merging #5877 (aa0c09a) into master (2920ed3) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5877      +/-   ##
==========================================
+ Coverage   66.89%   66.93%   +0.03%     
==========================================
  Files         130      130              
  Lines        4151     4159       +8     
  Branches      637      640       +3     
==========================================
+ Hits         2777     2784       +7     
+ Misses        999      997       -2     
- Partials      375      378       +3     
Impacted Files Coverage Δ
packages/server/src/api/controllers/view/utils.js 51.21% <0.00%> (+0.60%) ⬆️
...ges/server/src/api/controllers/view/viewBuilder.js 72.50% <0.00%> (+2.80%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c35c37...aa0c09a. Read the comment docs.

Copy link
Member

@shogunpurple shogunpurple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This is actually a very significant enhancement and turns on a lot of Mongos features in this connector.

@melohagan melohagan merged commit 26e7180 into master May 16, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2022
@Rory-Powell Rory-Powell deleted the fix/5613-5387 branch May 17, 2022 07:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't figure out how to do a delete request using the mongoDB connector
5 participants