-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
angular gen2 sdk with new approach #3315
angular gen2 sdk with new approach #3315
Conversation
🦋 Changeset detectedLatest commit: a7b72a0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
24e9b7f
to
00f052d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
You're missing the changeset @sidmohanty11
Description
This PR uses the latest angular generator updates to fix a ton of issues with our angular gen2 SDK like reactivity, symbols, data bindings, style bindings, some custom blocks etc and temporarily overrides video block -> we need to add ref to spread props to a
<video>
tag and spread it onChanges.Loom (angular sdk as of now)
https://www.loom.com/share/10c4b76eae9d48fba36ad0913db95ede