-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ci for prettier check and build #48
Conversation
not found case, using body as fallback.
…or (body) is not found.
selector from comments suggestions
resource excluded routes
core.ts, that way users can download a list of urls from the sitemap.xml, also added an abort if the crawler finds resource that is blocked.
- name: Run prettier | ||
run: npm run prettier:check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Static tests could run on git hooks/pre-commits as well along with a linter 😄. What do you think?
add `cross-env` package to avoid Node errors
I gave rebasing a shot, and I'm crossing my fingers that I got it right. 🧐 I always feel a bit on edge when I'm rebasing branches, especially when there are conflicts involved. |
Refactor getPageHtml function to handle selector not found case, using body as fallback. Add support for downloading URLs from sitemap.xml. Update comments to let know that sitemap is supported
Change LICENSE from MIT to ISC
chore: add `!package-lock.json` and `!tsconfig.json` to `.gitignore`
…rkflow feat: CLI release workflow
Add .gitignore entries for pnpm-lock.yaml
apologies, we just merged a few more things, needs one more round of conflict resolution and then we can get this in! |
Fix for Issue BuilderIO#66 | Docker run fails due to "Cannot find module '/home/myuser/dist/main.js'" | Error in Docker container
@steve8708 resolved conflicts ✅ |
@kunal00000, I see lots of overrides from changes that were already integrated to the main branch on this PR. It occurs to me that this might introduce some inconsistencies to the git history. Can you open a new PR including the prettier check? It will help us keep the repository and its git history clean 😄 |
Also, here's a step by step to rebase and preserve the repo git history from a forked repo (adapted from https://stackoverflow.com/a/7244456/9317004) # Add the remote, call it "upstream":
git remote add upstream git@github.com:BuilderIO/gpt-crawler.git
# Fetch all the branches of that remote into remote-tracking branches
git fetch upstream
# Make sure that you're on your main branch:
git checkout main
# Rewrite your master branch so that any commits of yours that
# aren't already in upstream/master are replayed on top of that
# other branch:
git rebase upstream/main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm leaving a suggestion to open a new PR including only the changes for the prettier check step on CI since this PR duplicates the git history (per #48 (comment))
Thanks @marcelovicentegc 🤠. created another PR for this. |
Added CI for prettier check and build on PRs and pushes.
Resolves #47