fix(qwik): fix missing class attribute #1133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mhevery
force-pushed
the
pr-misko-missing-class
branch
from
17539ea
to
a64d884
Compare
samijaber
reviewed
Apr 19, 2023
| @@ -383,6 +383,8 @@ const componentMappers: { | |||
| }), | |||
| }; | |||
| const properties = { ...block.properties }; | |||
| if (block.id) properties['block-id'] = block.id; | |||
| if (block.class) properties['class'] = block.class; | |||
There was a problem hiding this comment.
worth pointing out that this 2nd line did not add anything to snapshots. Is it redundant? Or do snapshot tests not cover the usecase for it?
There was a problem hiding this comment.
Yes that is the important bit. Will update the tests.
samijaber
reviewed
Apr 19, 2023
Comment on lines
229
to
250
| expect(mitosis.trim()).toEqual(dedent` | ||
| import { For } from "@builder.io/mitosis"; | ||
|
|
||
| export default function MyComponent(props) { | ||
| return ( | ||
| <For each={state.submenusItem.menuItems}> | ||
| {(item, index) => ( | ||
| <div | ||
| block-id="builder-ID" | ||
| class="class-id" | ||
| css={{ | ||
| padding: "2px", | ||
| }} | ||
| > | ||
| text-content | ||
| </div> | ||
| )} | ||
| </For> | ||
| ); | ||
| } | ||
| `); | ||
| }); |
There was a problem hiding this comment.
Can we use toMatchSnapshot instead?
samijaber
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a short description of:
This sort of information is useful for people reviewing the code, as well as anyone from the future trying to understand why changes were made or why a bug started happening.