fix: Fix input reactivity in useResource$() tutorial
#5818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restored dynamic input reactivity in the `useResource$()` tutorial by updating the `onInput$` handler to properly reflect changes. Previously, updates to the `github.org` input did not refresh repository data due to static value assignment, preventing the expected reactive behavior.
👷 Deploy request for qwik-insights pending review.Visit the deploys page to approve it
|
wmertens
reviewed
Feb 5, 2024
| <input | ||
| value={github.org} | ||
| onInput$={(ev) => | ||
| (github.org = (ev.target as HTMLInputElement).value) |
There was a problem hiding this comment.
The reason it wasn't working is because github.org wasn't being assigned in onInput$.
However, in your fix you're no longer using the invoking element, which is the correct way to read input events. Please fix this so we can merge.
wmertens
requested changes
Feb 5, 2024
|
Thanks @wmertens - I believe now it's everything ok 🤞 |
kodiakhq bot
pushed a commit
to ascorbic/unpic-img
that referenced
this pull request
Feb 11, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@builder.io/qwik](https://qwik.builder.io/) ([source](https://togithub.com/BuilderIO/qwik/tree/HEAD/packages/qwik)) | [`1.4.3` -> `1.4.4`](https://renovatebot.com/diffs/npm/@builder.io%2fqwik/1.4.3/1.4.4) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>BuilderIO/qwik (@​builder.io/qwik)</summary> ### [`v1.4.4`](https://togithub.com/BuilderIO/qwik/releases/tag/v1.4.4) [Compare Source](https://togithub.com/BuilderIO/qwik/compare/v1.4.3...v1.4.4) #### What's Changed - feat(vite): make linting op-out by [@​wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5801 - fix(core): assign refs without reactivity during SSR by [@​wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5802 - fix(docs): correct minor typos by [@​kylerush](https://togithub.com/kylerush) in [QwikDev/qwik#5804 - chore(starters): update 🐼 PandaCSS integration starter dev dependency by [@​mrhoodz](https://togithub.com/mrhoodz) in [QwikDev/qwik#5806 - fix(scoped styles): [@​container](https://togithub.com/container) block by [@​wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5813 - chore: ci e2e: single worker and longer timeout by [@​wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5814 - fix(link): Prefetch redirects to error pages. Fixes [#​5474](https://togithub.com/BuilderIO/qwik/issues/5474) by [@​iamriajul](https://togithub.com/iamriajul) in [QwikDev/qwik#5817 - chore: publish qwik-react with types by [@​wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5819 - fix: Fix input reactivity in `useResource$()` tutorial by [@​alexcsandru](https://togithub.com/alexcsandru) in [QwikDev/qwik#5818 - docs: fix qwik-nutshell example by [@​ozanmakes](https://togithub.com/ozanmakes) in [QwikDev/qwik#5824 - chore(starters): update 🐼 PandaCSS integration starter dev dependency by [@​mrhoodz](https://togithub.com/mrhoodz) in [QwikDev/qwik#5825 - chore: 1.4.4 by [@​wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5828 #### New Contributors - [@​kylerush](https://togithub.com/kylerush) made their first contribution in [QwikDev/qwik#5804 - [@​alexcsandru](https://togithub.com/alexcsandru) made their first contribution in [QwikDev/qwik#5818 - [@​ozanmakes](https://togithub.com/ozanmakes) made their first contribution in [QwikDev/qwik#5824 **Full Changelog**: QwikDev/qwik@v1.4.3...v1.4.4 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 9pm on sunday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ascorbic/unpic-img). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE3My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description
Restored dynamic input reactivity in the
useResource$()tutorial by updating theonInput$handler to properly reflect changes. Previously, updates to thegithub.orginput did not refresh repository data due to static value assignment, preventing the expected reactive behavior.Checklist: