Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SimpleImpactAnalysis and CostCategory to PackageOfMeasures #205

Merged
merged 8 commits into from
Aug 27, 2020

Conversation

macintoshpie
Copy link
Contributor

No description provided.

> f. Estimated level (high, medium, low) of return on investment (ROI)
> g. Priority (high, medium, low)

Additionally, Standard 211 is explicit in discriminating the "Low-Cost and No-Cost" recommendations (section 6.1.5) from the "Capital" recommendations (section 6.1.6), so it might not be a bad idea to add a category to specify this.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it can be argued that this discrimination is unnecessary/redundant because we apready specify the estimated cost (high, medium, low). Something to consider.

@macintoshpie macintoshpie marked this pull request as ready for review July 27, 2020 18:16
@markborkum
Copy link
Contributor

This is a breaking change, but it should be feasible to implement in Audit Template.

Audit Template's current usage profile for the auc:PackageOfMeasures element is limited to the following child elements:

  • auc:AnnualSavingsCost
  • auc:AnnualSavingsByFuels
  • auc:AnnualPeakElectricityReduction
  • auc:NetPresentValue

All appear to be moved by this PR to the new auc:ComplexImpactAnalysis element.

@macintoshpie macintoshpie marked this pull request as draft July 27, 2020 19:21
@macintoshpie
Copy link
Contributor Author

Waiting to fully finish 211 <> BuildingSync mapping before making final decisions about the proposal.
ie Don't merge this for now.

@macintoshpie macintoshpie added DO NOT MERGE STD 211 Mapping Related to the effort of mapping ASHRAE 211 levels to BuildingSync labels Jul 29, 2020
@macintoshpie macintoshpie marked this pull request as ready for review August 26, 2020 20:24
Copy link
Contributor

@markborkum markborkum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, thanks.

@macintoshpie macintoshpie merged commit 97db967 into develop Aug 27, 2020
@macintoshpie macintoshpie added the Schema: Reports Update to reports label Sep 2, 2020
@macintoshpie macintoshpie changed the title Feat/simple impact analysis proposal Add SimpleImpactAnalysis and CostCategory to PackageOfMeasures Sep 2, 2020
@macintoshpie macintoshpie deleted the feat/simple-impact-analysis-proposal branch September 14, 2020 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Non-breaking Change Schema: Reports Update to reports STD 211 Mapping Related to the effort of mapping ASHRAE 211 levels to BuildingSync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants