-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add choice for multiple auc:WallIDs within auc:Side #223
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Introducing the xsd:choice
element means that this would still be a breaking change for Audit Template, which would need to test the element being specified, and then either reject all auc:WallIDs
elements or select the first auc:WallID
for each auc:WallIDs
element.
Also, from a philosophical perspective, I'm not sure if this change makes sense.
In BuildingSync, the "facility", "site", "building" and "section" concepts are descriptions of the interiors of surfaces in 3-dimensional space. We infer facts from the presence of XML elements, e.g., "there is a building within the interior of this surface" because of a given auc:Building
element, and we infer part/whole relationships from the XML document object model, e.g., "this site is part of this facility" because a given auc:Site
element is a child of a given auc:Facility
element.
The "side" concept is a description of distinct slice of the surface for a "section" concept. We assert facts like "this side is touching a wall" by writing the auc:WallID
element. Importantly, if we glue together the slices for each "side" concept for a given "section" concept, we recover the entire surface.
Q: If a "side" represents a distinct slice of a surface, then does it make sense for a "side" to be touching more than one wall?
Q: If "walls" of 2 or more different materials are stacked horizontally or vertically, such that each slice of the "wall" is distinct, then would it make more sense to have a distinct "side" for each distinct "wall"? Or, is "stacking" a new characteristic of the "wall" itself that should be defined by the auc:WallSystemType
element?
Hey @markborkum - I'll try to provide a few clarifications:
This can basically all be summarized by the following graphic. If we were to get really fancy, we would add capabilities to define how walls are related to one another on a side, however, that is out of scope for 211 Level 2 audit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@corymosiman12 Makes sense, thanks.
@markborkum would you rather we just remove the choice and have users use |
@macintoshpie No. For the time being, please keep the |
No description provided.