#652 login #127
#652 login #127
Conversation
| { | ||
| id: GoogleLoginProvider.PROVIDER_ID, | ||
| provider: new GoogleLoginProvider( | ||
| '257845957103-qdi3hno6v1bf4lli44km2av2gijrs758.apps.googleusercontent.com' |
There was a problem hiding this comment.
is it possible that this not be hard coded?
There was a problem hiding this comment.
I think it's possible, but I think it's maybe too much work for this pr? I can add a todo, create a ticket, and tackle this kind of refactor later?
There was a problem hiding this comment.
I'll see how much effort this is, maybe i can do it now, but i have a feeling for deployment, it will need some work to inject these variables in somehow
| } | ||
|
|
||
| async loginWithGoogle(): Promise<void> { | ||
| await this.socialAuthService.signIn(GoogleLoginProvider.PROVIDER_ID); // TODO:: try option {ux_mode: 'redirect'} |
There was a problem hiding this comment.
yea, i may want to try this, i need a hand from patrick though, will confirm by next pr
| } else { | ||
| return { | ||
| headers: { | ||
| idToken, |
There was a problem hiding this comment.
small detail, should the header be id_token like we've done in onpoint/jetstream?
| <span class="title"><b>UDMI</b> Device Management Console</span> | ||
| <span class="spacer"></span> | ||
| <nav role="navigation" aria-label="Main navigation"> | ||
| <a mat-button routerLink="/devices" routerLinkActive="active">Devices</a> | ||
| </nav> | ||
| <button mat-button [matMenuTriggerFor]="userMenu" aria-label="User menu"> | ||
| <span>Hi Marc!</span> | ||
| <span>{{ displayName | async }}</span> |
There was a problem hiding this comment.
Optional - We could also show the google user image here instead of the displayName.
There was a problem hiding this comment.
that's an option, maybe i can try that at some point and show you to see how it looks
No description provided.