PHPCS/Composer: update PHPCompatibility #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Composer:
* `wimg/php-compatibility` has been abandoned for nearly a year. Use `phpcompatibility/php-compatibility` instead.
* Use the latest version of PHPCompatibility.
You were missing out on a lot of new checks, including the checks to make sure your code is compatible with the upcoming PHP 7.4.
* Add the DealerDirect Composer PHPCS plugin.
This plugin will handle setting the PHPCS `installed_paths` automatically.
This also allows for referencing the ruleset by name instead of via the path in the ruleset, which is generally more stable.
PHPCS ruleset:
* Rename the ruleset to `phpcs.xml.dist` which will allow PHPCS to automatically pick up on it.
No need to pass the `--standard=...` command-line argument anymore.
Includes removing the argument from the Travis script.
* Check for cross-version compatibility for the PHP versions officially supported.
According to the `composer.json` file, this code should be compatible with PHP 5.6 and above.
PHPCompatibility _was_ checking against PHP 5.5 up to PHP 7.1.
The new `testVersion` actually checks against PHP 5.6 up to the latest version (upcoming 7.4 at this moment).
Refs:
* https://github.com/PHPCompatibility/PHPCompatibility#sniffing-your-code-for-compatibility-with-specific-php-versions
* https://github.com/PHPCompatibility/PHPCompatibility/releases/
* https://github.com/Dealerdirect/phpcodesniffer-composer-installer
Codecov Report
@@ Coverage Diff @@
## master #26 +/- ##
=========================================
Coverage 99.59% 99.59%
Complexity 267 267
=========================================
Files 19 19
Lines 741 741
=========================================
Hits 738 738
Misses 3 3Continue to review full report at Codecov.
|
|
@jrfnl Thank you for PR. |
|
@Bukashk0zzz You're welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Composer:
wimg/php-compatibilityhas been abandoned for nearly a year. Usephpcompatibility/php-compatibilityinstead.You were missing out on a lot of new checks, including the checks to make sure your code is compatible with the upcoming PHP 7.4.
This plugin will handle setting the PHPCS
installed_pathsautomatically.This also allows for referencing the ruleset by name instead of via the path in the ruleset, which is generally more stable.
PHPCS ruleset:
phpcs.xml.distwhich will allow PHPCS to automatically pick up on it.No need to pass the
--standard=...command-line argument anymore.Includes removing the argument from the Travis script.
According to the
composer.jsonfile, this code should be compatible with PHP 5.6 and above.PHPCompatibility was checking against PHP 5.5 up to PHP 7.1.
The new
testVersionactually checks against PHP 5.6 up to the latest version (upcoming 7.4 at this moment).Refs: