[B+C] Add entry-related methods to scoreboard API. Adds BUKKIT-5779 #1108
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue:
Most methods in the scoreboard API which pertain to OfflinePlayer have been deprecated in favor of the use of entries. However, some methods remain without an entry-related alternative.
Justification:
If OfflinePlayers in relation to the scoreboard API are to be deprecated, the change should be thorough and offer an alternative for all methods.
PR Breakdown:
Add getEntryTeam(String) to Scoreboard.class
Add getEntries(), addEntry(String), removeEntry(String), and hasEntry(String) to Team.class
Deprecate getPlayerTeam(OfflinePlayer) in Scoreboard.class
Deprecate getPlayers(), addPlayer(OfflinePlayer), removePlayer(OfflinePlayer), and hasPlayer(OfflinePlayer) in Team.class
Testing Results and Materials:
The new scoreboard API methods function as expected when employed in a basic plugin.
Relevant PRs:
CB-1410
JIRA Ticket:
BUKKIT-5779