Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[B+C] Add entry-related methods to scoreboard API. Adds BUKKIT-5779 #1108

Closed
wants to merge 1 commit into from

Conversation

caseif
Copy link

@caseif caseif commented Aug 22, 2014

The Issue:

Most methods in the scoreboard API which pertain to OfflinePlayer have been deprecated in favor of the use of entries. However, some methods remain without an entry-related alternative.

Justification:

If OfflinePlayers in relation to the scoreboard API are to be deprecated, the change should be thorough and offer an alternative for all methods.

PR Breakdown:

Add getEntryTeam(String) to Scoreboard.class
Add getEntries(), addEntry(String), removeEntry(String), and hasEntry(String) to Team.class
Deprecate getPlayerTeam(OfflinePlayer) in Scoreboard.class
Deprecate getPlayers(), addPlayer(OfflinePlayer), removePlayer(OfflinePlayer), and hasPlayer(OfflinePlayer) in Team.class

Testing Results and Materials:

The new scoreboard API methods function as expected when employed in a basic plugin.

Relevant PRs:

CB-1410

JIRA Ticket:

BUKKIT-5779

Deprecate OfflinePlayer-related methods
@caseif caseif changed the title Add entry-related methods to scoreboard API. Adds BUKKIT-5779 [B + C] Add entry-related methods to scoreboard API. Adds BUKKIT-5779 Aug 24, 2014
@caseif caseif changed the title [B + C] Add entry-related methods to scoreboard API. Adds BUKKIT-5779 [B+C] Add entry-related methods to scoreboard API. Adds BUKKIT-5779 Aug 24, 2014
@caseif caseif closed this Mar 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant