[B + C] Adds a villager trading API. Adds BUKKIT-2138, BUKKIT-3935 #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param trade a new trade for the villager to perform | ||
| */ | ||
| public void addTrade(MerchantTrade trade); | ||
|
|
| * | ||
| * @param price the price of the trade, a maximum of two items | ||
| */ | ||
| public void setPrice(ItemStack... price) { |
There was a problem hiding this comment.
Needs a throws IllegalArgumentException in the Javadoc and a throws on the end of the method
|
This will be useful! I hope this PR will be accepted! |
|
The core team has stated that this does not feel like an appropriate way to approach villager trading; one problem is that the idea of a "Merchant" and its purpose is very ill-defined. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue:
Currently in bukkit there is no way to get or set merchant trades or get a merchant from its inventory
PR Breakdown:
This PR adds a way to get, set and add merchant trades and adds a way to get the merchant from the MerchantInventory
Testing Results and Materials:
https://github.com/thefishlive/Bukkit-test - source
https://www.dropbox.com/sh/9v7cy8c2acsuywn/mqdvl8kL3S/Bukkit-Test-0.0.1-SNAPSHOT.jar - binary
Relevant PR(s):
CB-1111 -Bukkit/CraftBukkit#1111 - implmentation
JIRA Ticket:
https://bukkit.atlassian.net/browse/BUKKIT-2138
https://bukkit.atlassian.net/browse/BUKKIT-3935