Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpv: Fix unwanted window when playing audio stream from terminal #88

Merged
merged 2 commits into from
Jun 21, 2018

Conversation

johnraff
Copy link
Member

@johnraff johnraff commented May 31, 2018

Suggested workaround for issues #86 and #87.

I'm assuming mpv has no deeper knowlege of the file transfer protocol than the start of the URI, so testing it in bl-mpv before choosing a profile, replacing use of mpv's auto profiles [protocol.http], [protocol.https] and [protocol-ytdl]. This leaves the mpv command relatively close to the factory default settings.

bin/bl-mpv: Use custom [bl-pseudo-gui] profile to invoke pseudo-GUI mode.
Test for http{,s} or ytdl protocols and invoke new [bl-http], [bl-https] or [bl-ytdl] profile.
Remove '--terminal=no' and '--input-terminal=no' from command line;
they are invoked in mpv's [builtin-pseudo-gui] and our [bl-pseudo-gui].

mpv/mpv.conf: Add [bl-http], [bl-https] and [bl-ytdl], invoked from bl-mpv,
to replace the auto profiles [protocol.http], [protocol.https] and [protocol-ytdl].
Add [bl-pseudo-gui] to invoke pseudo-gui mode and set screenshot directory;
this replaces calls to the deprecated [pseudo-gui] profile (see man mpv).

bin/bl-mpv: Use custom bl-pseudo-gui profile to invoke pseudo-GUI mode.
    Test for http{,s} protocol and invoke [http-https] profile.
    Remove '--terminal=no' and '--input-terminal=no' from command line;
     they are invoked in [builtin-pseudo-gui] and [bl-pseudo-gui].

mpv/mpv.conf: Add [http-https], invoked from bl-mpv,
     to replace the auto profiles [protocol.http] and [protocol.https].
    Add [bl-pseudo-gui] to invoke pseudo-gui mode and set screenshot directory;
     this replaces calls to the deprecated [pseudo-gui] profile (see man mpv).
mpv/mpv.conf: Split and rename http https profiles, add ytdl profile.
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@johnraff johnraff merged commit 5db2d6c into helium Jun 21, 2018
johnraff added a commit that referenced this pull request Jun 21, 2018
mpv: Fix unwanted window when playing audio stream from terminal

bin/bl-mpv:

Use custom bl-pseudo-gui profile to invoke pseudo-GUI mode.
Test for http{,s} and ytdl protocols and invoke [bl-http], [bl-https]
 or [ytdl] profile.
Remove '--terminal=no' and '--input-terminal=no' from command line;
 they are invoked in [builtin-pseudo-gui] and [bl-pseudo-gui].

mpv/mpv.conf:

Add [bl-http], [bl-https] and [bl-ytdl], invoked from bl-mpv,
 replacing auto profiles [protocol.http], [protocol.https] and [protocol.ytdl].
Add [bl-pseudo-gui] to invoke pseudo-gui mode and set screenshot directory;
 this replaces calls to the deprecated [pseudo-gui] profile (see man mpv).
@johnraff johnraff deleted the mpv-gui-fix branch October 22, 2019 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant