-
Notifications
You must be signed in to change notification settings - Fork 21
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aerosnap limping on deprecated syntax #16
Comments
Thanks for your contribution and my apologies for the delay in a response! This is now fixed in my fork. Pylint now reports:
The -0.39 comes from a big TODO comment I just added to remind myself what needs to be done still. |
@Unia Looks great, your fork. Do you intend on merging your commit with this repo at some point or should i follow yours separately? |
I intend to make a PR when all issues are resolved :) |
No, but I do not have time to continue development right now. |
OK no problem. |
For lack of interest, bl-aerosnap has been removed from bunsen-utilities. |
So got around to incorporating aerosnap in my setup and noticed this problem. The lint indicated that the syntax in lines 115 and 123 is deprecated. The funny thing is that the conditional works because of the deprecated syntax. Consider,
is_root_window
is actually a function and should have been called. Rather the value of the reference (which is the function object) is being tested againstTrue
which would always result in the conditional being true (and the program would enter the subsequent loop) even when the window is the root window. Not that it would bring about any drastic change (like changing the geometry of the root window), but I thought I would mention it for the sake of correctness.I have prepared the following patch. The rest of the edits are just lint-based. No changes in the logic.
The text was updated successfully, but these errors were encountered: