Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support Throughput::Elements #4

Merged
merged 1 commit into from
Mar 18, 2021

Conversation

tko
Copy link
Contributor

@tko tko commented Jun 11, 2020

Example output:

base     1.00    683.6±86.03µs  5.7 MElem/sec
  • add CThroughput::elements to de/serialize the values
  • replace Benchmark.bytes_per_second with a Throughput enum and adjust
    the output to print B/sec or Elem/sec accordingly

Fixes: #3

Example output:
```
base     1.00    683.6±86.03µs  5.7 MElem/sec
```

- add CThroughput::elements to de/serialize the values
- replace Benchmark.bytes_per_second with a Throughput enum and adjust
  the output to print B/sec or Elem/sec accordingly

Fixes: BurntSushi#3
@jszwedko
Copy link

👍 just ran into this too. This would be great to have.

@jszwedko
Copy link

@BurntSushi Is there any chance this PR could go in? Sorry, I know this sort of nudge can be annoying, but I ran across its lack again today and find critcmp generally useful. Thank you for providing this tool!

Copy link
Owner

@BurntSushi BurntSushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Sorry about the delay.

@BurntSushi BurntSushi merged commit daaf038 into BurntSushi:master Mar 18, 2021
@BurntSushi
Copy link
Owner

This PR is in critcmp 0.1.6 on crates.io.

@tko tko deleted the throughput-elements branch March 19, 2021 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Throughput::Elements shown as "? B/sec"
3 participants