Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throughput::Elements shown as "? B/sec" #3

Closed
tko opened this issue Jun 10, 2020 · 0 comments · Fixed by #4
Closed

Throughput::Elements shown as "? B/sec" #3

tko opened this issue Jun 10, 2020 · 0 comments · Fixed by #4

Comments

@tko
Copy link
Contributor

tko commented Jun 10, 2020

I've a benchmark using Throughput::Elements but that's not accounted for in the output and instead is only displayed as "? B/sec" as if throughput wasn't used.
tko added a commit to tko/critcmp that referenced this issue Jun 11, 2020
@tko
support Throughput::Elements
d1e8644 
- add CThroughput::elements to de/serialize the values
- replace Benchmark.bytes_per_second with a Throughput enum and adjust
- the output to print B/sec or Elem/sec accordingly

Fixes: BurntSushi#3
tko added a commit to tko/critcmp that referenced this issue Jun 11, 2020
@tko
support Throughput::Elements
5cde4ae 
Example output:
```
base     1.00    683.6±86.03µs  5.7 MElem/sec
```

- add CThroughput::elements to de/serialize the values
- replace Benchmark.bytes_per_second with a Throughput enum and adjust
- the output to print B/sec or Elem/sec accordingly

Fixes: BurntSushi#3
tko added a commit to tko/critcmp that referenced this issue Jun 11, 2020
@tko
support Throughput::Elements
94bac7c 
Example output:
```
base     1.00    683.6±86.03µs  5.7 MElem/sec
```

- add CThroughput::elements to de/serialize the values
- replace Benchmark.bytes_per_second with a Throughput enum and adjust
  the output to print B/sec or Elem/sec accordingly

Fixes: BurntSushi#3
@tko tko mentioned this issue Jun 11, 2020
Merged
@plaflamme plaflamme mentioned this issue Oct 4, 2020
Closed
BurntSushi pushed a commit that referenced this issue Mar 18, 2021
@tko
data: support Throughput::Elements
daaf038 
Example output:

    base     1.00    683.6±86.03µs  5.7 MElem/sec

Fixes #3, Closes #9, PR #4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@tko