Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What is your plan for Season 2018 ? #363

Open
irish1986 opened this issue Jul 23, 2018 · 24 comments
Open

What is your plan for Season 2018 ? #363

irish1986 opened this issue Jul 23, 2018 · 24 comments

Comments

@irish1986
Copy link

This project is officially unmaintain. What are you planning for this coming season ? Are you going to self maintain individually this repo at home or are you migrating to something else (if so, what is it).

This python package had been one of the best tool for my fantasy football season so I am curious to learn about other people plan.
@rjhaz
Copy link

rjhaz commented Jul 23, 2018 via email

@donlaur
Copy link

donlaur commented Jul 23, 2018 via email

@rjhaz
Copy link

rjhaz commented Jul 23, 2018 via email

@ochawkeye
Copy link
Contributor

I'll be running nflgame just as I have for the past 5 seasons. Yes, it is technically un-maintained, but if we're being honest - and I don't think @BurntSushi would disagree - it wasn't being actively maintained much last year and it still worked just fine for what I needed it for. So long as the underlying Game Center JSON doesn't change much, I have full confidence that this will keep right on chugging.

@derek-adair
Copy link
Contributor

I will absolutely be using this project just as @ochawkeye.

I'd be glad to contribute. It seems like its pretty much usable as is anyways.

@ochawkeye
Copy link
Contributor

ochawkeye commented Jul 30, 2018 •
edited
Loading

Maybe too early to tell, but this could potentially be our first opportunity to roll up our sleeves and modify nflgame for future generations.

I've been watching with a bit of surprise that http://www.nfl.com/liveupdate/scorestrip/ss.xml has failed to move off of 2017 week 17 despite the 2018 schedule being released for quite some time.

I began poking around on NFL.com a bit and discovered that there is actually an XML out there with week-by-week schedules in identical format to what we're accustomed to seeing:
ie. http://www.nfl.com/ajax/scorestrip?season=2018&seasonType=REG&week=1.

No telling if the NFL will eventually resurrect the same old scorestrip on their Game Center pages, but I'd say there's at chance that they don't as at this time old games no longer have the strip toward the top of the screen that allows navigation to any other game that week.

Edit: Nice detective work Sherlock:

nflgame/nflgame/update_sched.py

Line 40 in db6a0b3

xmlurl = 'http://www.nfl.com/ajax/scorestrip?'

@ochawkeye
Copy link
Contributor

OK, this probably won't be a problem. The reason schedule.json is not updating is because update_sched.py only looks at the years 2009 through the year that live.current_year_and_week() says it currently is. Since live.current_year_and_week() thinks it is still 2017 (according to live.CUR_SCHEDULE) even if you ask it to update --year 2018 it bails out and leaves schedule.json alone.

If you absolutely have to see nflgame give you an updated schedule, change this line to range(2009, cur_year+2) and re-run ...\nflgame\update_sched.py --year 2018. You'll find all of the 2018 preseason and regular season games now appear in your schedule.json file.

@ochawkeye ochawkeye mentioned this issue Jul 31, 2018
Open
@brbeaird
Copy link

Glad to see you guys putting some time and effort into keeping this going. Thanks!

@salfaro
Copy link

salfaro commented Jul 31, 2018 •
edited
Loading

is there an alternative to nflgame ? I need to run some models for my predictions.

EDIT: I heavily used nflgame libraries from 2014 to 2016. I never bothered to investigate HOW nflgame worked. It was just working fine. I didn't use it in 2017 because my mind was in a family situation. Last week I was trying to pick up where I left. When I was trying to get all the results for 2017, I got an error saying TypeError: 'NoneType' object is not iterable. Then, I came to this github page and saw 'Project is unmaintained'. That is when I freaked out and asked for an alternative to nflgame. I had to make a little research and jump into the nflgame code. I followed advise from @ochawkeye and got into update_sched.py file, modified the line and re-run it. However, instead of using --year 2018 as parameter, I ran it with --rebuild as parameter. Now my old code works like a charm! :)

(Sorry for my English)

@derek-adair
Copy link
Contributor

@ochawkeye - you da real MVP.

@mickeelm
Copy link

mickeelm commented Aug 3, 2018

Chiming in here too - glad to see that there are initiatives to keep this going. As already pointed out, this project will probably be usable for a long time to come given that nfl.com doesn't make any major changes.

However, in order for this to keep going and develop (like @ochawkeye pointed out, to "roll up our sleeves") I guess some kind of "official fork" would be preferable. There are 118 open issues in this repo right now (hard to know which matter anymore and which does not) and helping each other out via comments in the issues here just isn't gonna cut it in the long run, the project simply needs to move on to a fresh start :)

@ochawkeye, my impression is that your heart is in this and therefore I was just wondering - how do you feel about the idea that your fork would be the one to follow from now on? E.g. the place to submit issues, PRs, discuss, develop. Just asking carefully, no pressure! :)

Also, shoutout once again to @BurntSushi for all the great work during these years, a huge thank you!

@ThomasMorgani
Copy link

coming in to show some appreciation, support and to offer any contributions I can. I have leveraged nflgame/nfldb for my fantasy site for a few years now and would like to give back. Lets keep this thing alive.

@benlindsay
Copy link

I just tried this out today, bummer that it's not maintained, but thanks to @BurntSushi for putting this together! Not sure if I should start a new issue for this, but I have a problem where nflgame.games(2017, week=week) gives a TypeError for weeks 1-16, but it works fine for week 17. Does that have to do with this project not being maintained anymore?

@ochawkeye
Copy link
Contributor

@benlindsay Could be that nflgame is only updating the "current week" and your schedule is in need of an update. Try running python ...PATH\TO\nflgame\update_sched.py --year 2017

@mickeelm Not avoiding your question...just mulling over the responsibility associated with it. Truth is, I plan on having this running on my side so pushing it back to github really isn't a difficult thing to do. But I've seen the - literally - hundreds of queries that @BurntSushi has so patiently handled over the past 5 years and I'm not sure I'm capable of showing the restraint he has shown in fielding the majority of those.

@mickeelm
Copy link

mickeelm commented Aug 7, 2018

@ochawkeye I understand that 100%, I really do. 🙂 Thank you for an excellent and honest answer. While it would be easy for me to say "hey, no pressure and we'll all help out" I think that a cornerstone of these kind of non-profit open source projects is to feel joy working with it, it shouldn't be a burden. So then my advice from a personal viewpoint would be to just continue as you planned in the beginning. Time will tell if you feel like pushing it back to Github or not, and what will happen or not happen if you do. I'd probably clone it if you did push it, though 😉

I'm quite confident that this project will live on in one way or another. I also have my own project (small fantasy league) and I myself would say no right now to maintain an "official fork" for the exact reasons that you mention (also, I've only used nflgame as inspiration/taken small parts so far so I'm not super up-to-speed with the code). My plan (not promising anything though) is to build a REST-API for the database (also curious about making a NoSQL-version), since we are developing a new web site for our league. Will share it if I do.

So, let's just wait and see what happens here. Things tend to sort themselves out in the end!

@benlindsay
Copy link

@ochawkeye Your suggestion worked! Thanks for that!

@derek-adair
Copy link
Contributor

@ochawkeye @mickeelm I'll be glad to fork and patiently field any requests directed at the project. I am familiar with handling merge requests, building and releasing projects so I actually would welcome the opportunity to handle that for a project such as this.

@derek-adair derek-adair mentioned this issue Aug 8, 2018
Open
@mickeelm
Copy link

mickeelm commented Aug 8, 2018

@derek-adair I salute you for this! Really excited :)

@derek-adair
Copy link
Contributor

I'm not a very strong programmer but I can manage quite well so maybe this will work out. Anyone interested in participating please dont hesistate to do so ;)

@derek-adair derek-adair mentioned this issue Aug 9, 2018
Closed
@ochawkeye ochawkeye mentioned this issue Aug 10, 2018
Open
@derek-adair derek-adair mentioned this issue Aug 13, 2018
Open
@ochawkeye ochawkeye mentioned this issue Aug 15, 2018
Closed
@bryarwagner bryarwagner mentioned this issue Sep 7, 2018
Closed
@nickfrerichs
Copy link

nickfrerichs commented Sep 7, 2018 •
edited
Loading

Here's what I did.

In the file live.py, temporarily add this URL on line 68 after the old one.

_CUR_SCHEDULE = "http://www.nfl.com/liveupdate/scorestrip/ss.xml"
_CUR_SCHEDULE = "http://www.nfl.com/ajax/scorestrip?season=2018&seasonType=REG&week=1"

@mickeelm
Copy link

mickeelm commented Sep 7, 2018

@nickfrerichs if you don't want to bother updating that every week (and avoid external calls to nfl.com), check out the fork mentioned above (https://github.com/derek-adair/nflgame/). Apart from that issue it has other fixes and is actively maintained. If you just want the scheduling issue solved but not anything else, grab live.py from the fork.

@irish1986
Copy link
Author

@mickeelm I intent to make a large PR later this weekend to @derek-adair repo with my Py3 code and hopefully the community can get behind this repo for the continuation of this project. Hopefully this will allow the project to reborn and continue as @BurntSushi create a beautiful tool that a lot of football fan enjoy !

@tdoctor
Copy link

tdoctor commented Jan 2, 2019

A lot of great information in this post...thanks. I have been looking at the data returned from the liveupdate/game-center and am curious if anyone can point me to any documentation on the JSON elements. For instance "StatID"=79 is for a tackle. There are a lot of other codes in that JSON that would be great to see documentation on instead of having to figure them out manually. Thanks

@derek-adair
Copy link
Contributor

You can see the relevant map here

@tdoctor You are more than welcome to file issues like this in my forked repo. or even better if you have any insight into how the wiki can be updated i'll gladly get it in there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests