Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[WIP] Add support for compressed file formats (closes #539) #751
Creating this PR for review purposes. I still haven't added any tests for the newer code, which is one of the main things still pending here.
Any other thoughts and suggestions are welcome.
There is a problem with the completion function, and i added a few bike-shed wording remarks. I won't comment on the Rust stuff except to say that it does at least make sense to me.
I tested the patch on macOS (just briefly) and it works! This is neat as hell, ty!
BurntSushi left a comment •
@balajisivaraman Thanks so much for working on this! I really wanted to get this merged and there were some fiddly details to get right here, so I went ahead and based a new PR on your work here: #767. I hope that's OK. Most of your code made it through :-) but I did need to refactor the
I left some comments on this PR that roughly correspond to the changes I made.