Remove trailing semicolon from fail! macro #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the semicolon_in_expressions_from_macros lint is ever turned into a hard error, your crate will stop compiling. This commit ensures that your crate will compile on both current and future versions of Rust. See rust-lang/rust#79813 for more details
BurntSushi
reviewed
Feb 9, 2021
There was a problem hiding this comment.
This change doesn't quite make sense to me. This is a return statement, so the trailing semi-colon should be just fine. Indeed, this is exactly the style in which I would write a return statement outside of a macro. I expect to be able to do this just the same inside a macro.
|
This allows the macro to be used in expression position (e.g. |
BurntSushi
approved these changes
Feb 9, 2021
|
This PR is on crates.io in |
JohnTitor
pushed a commit
to JohnTitor/rust
that referenced
this pull request
Jan 27, 2023
As spotted by @mejrs, snap 1.0.1 emits a future compatibility warning. This was fixed in BurntSushi/rust-snappy#39
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jan 27, 2023
Update snap from `1.0.1` to `1.1.0` As spotted by `@mejrs,` snap 1.0.1 emits a future compatibility warning. This was fixed in BurntSushi/rust-snappy#39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the semicolon_in_expressions_from_macros lint is ever turned into a
hard error, your crate will stop compiling. This commit ensures that
your crate will compile on both current and future versions of Rust.
See rust-lang/rust#79813 for more details