Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change OsString args in sort_by to OsStr #44

Closed
KodrAus opened this issue Jun 14, 2017 · 1 comment
Closed

Change OsString args in sort_by to OsStr #44

KodrAus opened this issue Jun 14, 2017 · 1 comment

Comments

@KodrAus
Copy link
Contributor

KodrAus commented Jun 14, 2017

The WalkDir::sort_by method should take OsStr arguments instead of OsStrings.
This was referenced Jun 14, 2017
Closed
Closed
jeremielate added a commit to jeremielate/walkdir that referenced this issue Jun 17, 2017
@jeremielate
Support more metadata for sort_by
ff48a59 
Fixes BurntSushi#44 and BurntSushi#45.
jeremielate added a commit to jeremielate/walkdir that referenced this issue Jun 17, 2017
@jeremielate
Support more metadata for sort_by
e73b02c 
Fixes BurntSushi#44 and BurntSushi#45.
sjeohp-zz pushed a commit to sjeohp-zz/walkdir that referenced this issue Jun 21, 2017
@sjeohp
Change OsString args in sort_by to OsStr BurntSushi#44
a7903de
@KodrAus
Copy link
Contributor Author

KodrAus commented Jul 12, 2017

I'm going to close this issue, since we're solving this by re-working the sort_by implementation in #45.

cc: @BurntSushi

@KodrAus KodrAus closed this as completed Jul 12, 2017
BurntSushi pushed a commit that referenced this issue Jul 15, 2017
@jchlapinski @BurntSushi
WalkDir sorter should accept whole dir entries instead of just file n…
71ceae7 
…ames (#70)

change sort_by types

This changes the sort_by comparator function to accept a pair
of `&DirEntry`s, which permits the caller more flexibility with
sorting.

Fixes #44, Fixes #45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KodrAus