Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite post init as properties #149

Merged
merged 2 commits into from
Oct 1, 2022

Conversation

BurnySc2
Copy link
Owner

@BurnySc2 BurnySc2 commented Oct 1, 2022

No description provided.

@BurnySc2 BurnySc2 changed the title Rewrite post init as properties [WIP] Rewrite post init as properties Oct 1, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2022

Codecov Report

Merging #149 (dada3cf) into feature-unit-as-dataclass (a7241ec) will decrease coverage by 0.01%.
The diff coverage is 85.55%.

@@                      Coverage Diff                      @@
##           feature-unit-as-dataclass     #149      +/-   ##
=============================================================
- Coverage                      72.62%   72.61%   -0.02%     
=============================================================
  Files                            106      107       +1     
  Lines                          13929    13963      +34     
=============================================================
+ Hits                           10116    10139      +23     
- Misses                          3813     3824      +11     
Impacted Files Coverage Δ
sc2/game_state.py 75.97% <0.00%> (ø)
test/benchmark_prepare_units.py 0.00% <0.00%> (ø)
sc2/unit.py 82.28% <98.61%> (+0.24%) ⬆️
sc2/bot_ai_internal.py 85.40% <100.00%> (-0.08%) ⬇️
examples/zerg/zerg_rush.py 82.22% <0.00%> (-1.12%) ⬇️
examples/terran/onebase_battlecruiser.py 52.63% <0.00%> (+0.87%) ⬆️
examples/zerg/hydralisk_push.py 70.73% <0.00%> (+1.21%) ⬆️
examples/zerg/expand_everywhere.py 88.88% <0.00%> (+2.22%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@BurnySc2 BurnySc2 changed the title [WIP] Rewrite post init as properties Rewrite post init as properties Oct 1, 2022
@BurnySc2 BurnySc2 merged commit 0dace56 into feature-unit-as-dataclass Oct 1, 2022
@BurnySc2 BurnySc2 deleted the rewrite-post-init-as-properties branch October 1, 2022 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants