Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ported Dragablz to .Net Core 3.0 #232

Merged
merged 3 commits into from Oct 27, 2020
Merged

Conversation

Mrxx99
Copy link
Contributor

@Mrxx99 Mrxx99 commented Nov 2, 2019

This changed the old projects to the new project SDK which allows multitargeting.
It still targets .Net Framework 4.0 and 4.5 but now additional .Net Core 3.0.
I changed the mocking framework in the test project to FakeItEasy because it allows to be used from .Net 4.0 to .Net Core 3.0.

EDIT: I also deleted the nuspec file, since in the new project sdk this info can be added directly in the project (I copied the infos). That's why the CI build was failing.

@ButchersBoy
Copy link
Owner

Hi, I'll try and have a look at appveyor to get the build working

@jeremyVignelles
Copy link

@ButchersBoy ; Hey, good to see you back 🙂 Hope you're doing well.
I'm really looking forward any progress with this library 👍
Feel free to come and chat on gitter if you need help from the community to handle the issues.

@Mrxx99
Copy link
Contributor Author

Mrxx99 commented Apr 22, 2020

Great to see some activity here again :)

I think one point that failed the build was the deletion of nuspec file because I moved the infos of it into the csproj like suggested by microsoft which allows generating nuget package on build. I will try adding the nuspec again and see if build than succeeds

@jeremyVignelles
Copy link

nuspec shouldn't be needed if the CI is properly configured, right?

I would expect the nuspec file to be only used where there is no proj file

@akanieski
Copy link

I could use this nuget on a 3.1 project I'm working on as well.

@csutcliff
Copy link

csutcliff commented Jun 17, 2020

For anyone wanting a solution in the meantime @miroiu has a .net core 3.1 fork that's available on NuGet https://github.com/miroiu/Dragablz https://www.nuget.org/packages/Dragablz.NetCore/

@ButchersBoy ButchersBoy merged commit da7a4e5 into ButchersBoy:master Oct 27, 2020
@miroiu
Copy link

miroiu commented Oct 27, 2020

Hi! Thanks for upgrading this to .NET Core. I removed my listing from nuget.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants