Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

memory tracker for merge mutate is not correct #982

Closed
blueskygzhz opened this issue Dec 19, 2023 · 7 comments · Fixed by #1661
Closed

memory tracker for merge mutate is not correct #982

blueskygzhz opened this issue Dec 19, 2023 · 7 comments · Fixed by #1661
Assignees
@qusijun @luffyhwl @yuanzhubi
Labels
bug Something isn't working P2 minor issue

Comments

@blueskygzhz
Copy link
Contributor

pod memory cost is 32G, but memory tracker show 1T and never decrease

image

image
@blueskygzhz blueskygzhz added the bug Something isn't working label Dec 19, 2023
@yuanzhubi
Copy link
Collaborator

Let me add lianwenlong to confirm it.

@wordhardqi wordhardqi added the P2 minor issue label Dec 26, 2023
@qusijun qusijun self-assigned this Dec 27, 2023
@blueskygzhz
Copy link
Contributor Author

img_v3_026v_bbd6397f-bd1b-4eba-8e75-4c5148409e9g
this metric

@TKaxe TKaxe assigned yuanzhubi and unassigned TKaxe Jan 24, 2024
@yuanzhubi
Copy link
Collaborator

ClickHouse/ClickHouse#10449 could we merge this PR, to remove the unused and incorrect metric?
image
@qusijun

@kevinthfang
Copy link
Contributor

We are merging this PR from ck community.

@kevinthfang
Copy link
Contributor

We will merge this week.

@kevinthfang
Copy link
Contributor

This merge is still on the way

@luffyhwl
Copy link
Collaborator

The PR from ck community has been merged. (ClickHouse/ClickHouse#48787)

fanqi1909 pushed a commit that referenced this issue May 6, 2024
@jay-bytedance
Merge branch 'metrics-for-merge' into 'cnch-dev'
5916534 
fix(byconity@m-3000817252): cp new merge memory usage metric Closes #982

See merge request dp/ClickHouse!20227
@fanqi1909 fanqi1909 mentioned this issue May 6, 2024
Merged
fanqi1909 pushed a commit that referenced this issue May 13, 2024
@jay-bytedance
Merge branch 'metrics-for-merge' into 'cnch-dev'
324bbca 
fix(byconity@m-3000817252): cp new merge memory usage metric Closes #982

See merge request dp/ClickHouse!20227
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qusijun qusijun

@luffyhwl luffyhwl

@yuanzhubi yuanzhubi

Labels
bug Something isn't working P2 minor issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP Cherry-pick internal changes ByConity/ByConity
7 participants
@qusijun @luffyhwl @kevinthfang @wordhardqi @yuanzhubi @TKaxe @blueskygzhz