Add MemoryTracker for the background tasks [Resubmit] #48787

novikd · 2023-04-14T14:52:05Z

Changelog category (leave one):

New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Add MemoryTracker for the background tasks (merges and mutation). Introduces merges_mutations_memory_usage_soft_limit and merges_mutations_memory_usage_to_ram_ratio settings that represent the soft memory limit for merges and mutations. If this limit is reached ClickHouse won't schedule new merge or mutation tasks. Also MergesMutationsMemoryTracking metric is introduced to allow observing current memory usage of background tasks.
Resubmit #46089. Closes #48774.

Documentation entry for user-facing changes

Documentation is written (mandatory for new features)

…ound-memory-tracker" This reverts commit a61ed33, reversing changes made to 5f01b8a.

CheSema

Diff looks OK.
Some tests are failed.

robot-ch-test-poll3 · 2023-05-02T23:34:48Z

This is an automated comment for commit 93e8ecf with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🔴 failure

Check name	Description	Status
AST fuzzer	Runs randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help.	🟢 success
CI running	A meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR	🟢 success
ClickHouse build check	Builds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process.	🟢 success
Compatibility check	Checks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help.	🟢 success
Docker image for servers	The check to build and optionally push the mentioned image to docker hub	🟢 success
Docs Check	Builds and tests the documentation	🟢 success
Fast test	Normally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here.	🟢 success
Flaky tests	Checks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read https://clickhouse.com/blog/decorating-a-christmas-tree-with-the-help-of-flaky-tests/	🟢 success
Install packages	Checks that the built packages are installable in a clear environment	🟢 success
Integration tests	The integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests	🟢 success
Mergeable Check	Checks if all other necessary checks are successful	🟢 success
Performance Comparison	Measure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests	🟢 success
Push to Dockerhub	The check for building and pushing the CI related docker images to docker hub	🟢 success
SQLancer	Fuzzing tests that detect logical bugs with SQLancer tool.	🟢 success
Sqllogic	Run clickhouse on the sqllogic test set against sqlite and checks that all statements are passed.	🟢 success
Stateful tests	Runs stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc.	🟢 success
Stateless tests	Runs stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc.	🔴 failure
Stress test	Runs stateless functional tests concurrently from several clients to detect concurrency-related errors.	🔴 failure
Style Check	Runs a set of checks to keep the code style clean. If some of tests failed, see the related log from the report.	🟢 success
Unit tests	Runs the unit tests for different release types	🟢 success
Upgrade check	Runs stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts.	🟢 success

azat · 2023-05-16T15:35:08Z

src/Common/MemoryTracker.cpp

@@ -96,12 +96,17 @@ using namespace std::chrono_literals;
 static constexpr size_t log_peak_memory_usage_every = 1ULL << 30;

 MemoryTracker total_memory_tracker(nullptr, VariableContext::Global);
+MemoryTracker background_memory_tracker(&total_memory_tracker, VariableContext::User, false);


I guess it worth a comment (I guess it fixes this #48774 issue)
Also why is this a problem in the first place? Maybe there is something incorrect in waiting of thread pools?

We don't have an order when global objects are destroyed.

Maybe I described it not good enough, I meant that if threads was joined, then background_memory_tracker cannot be used anymore, so it should be enough to ensure that the threads was joined, or am I missing something?

background_memory_tracker do some staff in d-tor. That might be the problem I think. It calls some object which could be destroyed already.

novikd added 2 commits April 14, 2023 16:34

Revert "Merge pull request #48760 from ClickHouse/revert-46089-backgr…

cf5d9a1

…ound-memory-tracker" This reverts commit a61ed33, reversing changes made to 5f01b8a.

Do not log peak for background memory tracker

a1f21a5

robot-ch-test-poll1 added the pr-feature Pull request with new product feature label Apr 14, 2023

CheSema self-assigned this Apr 17, 2023

CheSema approved these changes Apr 17, 2023

View reviewed changes

novikd added 2 commits April 17, 2023 17:47

Update test.py

6f501f9

Update test

93e8ecf

alexey-milovidov merged commit a8bdb20 into master May 9, 2023
263 of 266 checks passed

alexey-milovidov deleted the background-memory-tracker branch May 9, 2023 04:58

azat reviewed May 16, 2023

View reviewed changes

novikd mentioned this pull request May 18, 2023

Soft memory limits for merges and mutations. #45710

Closed

luffyhwl mentioned this pull request Apr 23, 2024

memory tracker for merge mutate is not correct ByConity/ByConity#982

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add MemoryTracker for the background tasks [Resubmit] #48787

Add MemoryTracker for the background tasks [Resubmit] #48787

novikd commented Apr 14, 2023

CheSema left a comment

robot-ch-test-poll3 commented May 2, 2023 •

edited by robot-clickhouse-ci-1

azat May 16, 2023

novikd May 18, 2023

azat May 25, 2023

CheSema May 25, 2023

Add MemoryTracker for the background tasks [Resubmit] #48787

Add MemoryTracker for the background tasks [Resubmit] #48787

Conversation

novikd commented Apr 14, 2023

Changelog category (leave one):

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Documentation entry for user-facing changes

CheSema left a comment

Choose a reason for hiding this comment

robot-ch-test-poll3 commented May 2, 2023 • edited by robot-clickhouse-ci-1

azat May 16, 2023

Choose a reason for hiding this comment

novikd May 18, 2023

Choose a reason for hiding this comment

azat May 25, 2023

Choose a reason for hiding this comment

CheSema May 25, 2023

Choose a reason for hiding this comment

robot-ch-test-poll3 commented May 2, 2023 •

edited by robot-clickhouse-ci-1