Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API-195: Coveralls code coverage #44

Merged
merged 30 commits into from
Feb 3, 2021

Conversation

Arpit-Sharma-USC
Copy link
Contributor

update with upstream master
@Arpit-Sharma-USC Arpit-Sharma-USC marked this pull request as ready for review February 3, 2021 11:24
githuib
githuib previously approved these changes Feb 3, 2021
@githuib
Copy link
Contributor

githuib commented Feb 3, 2021

Error:  "2021-02-03T11:52:57.834Z"  'error from getOptions'
Error: Error: Command failed: git cat-file -p 27f28ad43308b63eb9e60f9fffb38dbd0c8b1151

Not sure what's causing this, but maybe you need to do the same as in the java PR here? (changing pull_request to pull_request_target)

Or is it just because it isn't merged yet?

@Arpit-Sharma-USC
Copy link
Contributor Author

Error:  "2021-02-03T11:52:57.834Z"  'error from getOptions'
Error: Error: Command failed: git cat-file -p 27f28ad43308b63eb9e60f9fffb38dbd0c8b1151

Not sure what's causing this, but maybe you need to do the same as in the java PR here? (changing pull_request to pull_request_target)

Or is it just because it isn't merged yet?

Yeah I am checking that out, I think it might be the later as the same commit doesn't fail on my repo

@Arpit-Sharma-USC
Copy link
Contributor Author

Error:  "2021-02-03T11:52:57.834Z"  'error from getOptions'
Error: Error: Command failed: git cat-file -p 27f28ad43308b63eb9e60f9fffb38dbd0c8b1151

Not sure what's causing this, but maybe you need to do the same as in the java PR here? (changing pull_request to pull_request_target)
Or is it just because it isn't merged yet?

Yeah I am checking that out, I think it might be the later as the same commit doesn't fail on my repo

Doesn't happen anymore, must have been a transient thing on the coverallsapp timestamping

@Arpit-Sharma-USC Arpit-Sharma-USC merged commit ceec7c6 into Bynder:master Feb 3, 2021
Arpit-Sharma-USC added a commit to Arpit-Sharma-USC/bynder-c-sharp-sdk that referenced this pull request Feb 3, 2021
API-195: Coveralls code coverage (Bynder#44)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants