Added a custom wrapper around windows commands to ignore explorer's exit status. #76
Conversation
| @@ -249,6 +259,23 @@ impl IntoResult<io::Result<()>> for io::Result<std::process::ExitStatus> { | |||
| } | |||
| } | |||
|
|
|||
| #[cfg(target_os = "windows")] | |||
There was a problem hiding this comment.
This seems unused, probably because it looks like a no-op. Am I missing something?
There was a problem hiding this comment.
This is where the special treatment of the explorer command results from (271-274):
The exit status of the Ok variant gets ignored (272) compared to the other commands, where an exit status other than 0 indicates an error (252-256) even if the result is Ok.
src/windows.rs
Outdated
| .status() | ||
| } | ||
|
|
||
| pub fn extract(self) -> Command { |
There was a problem hiding this comment.
This should be called into_command. Alternatively, From<WindowsRunCommand> can be implemented for Command.
src/windows.rs
Outdated
| impl Debug for WindowsRunCommand { | ||
| fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { | ||
| match self { | ||
| Self::Start(_) => write!(f, "start"), |
There was a problem hiding this comment.
I think it would be better to delegate to the inner cmd here, as every implementation prints everything it tries to execute. Windows shouldn't be different.
Moved extract for WindowsRunCommand to From<WindowsRunCommand> Made Debug for WindowsRunCommand use Command's Debug
Now use into<Command>() instead of extract()
No description provided.